Industrialization: add margins on memory limits #504
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: BOUHOURS Antoine <antoine.bouhours@rte-france.com>
Signed-off-by: BOUHOURS Antoine <antoine.bouhours@rte-france.com>
jonenst
approved these changes
May 21, 2025
Contributor
jonenst
left a comment
jonenst
left a comment
There was a problem hiding this comment.
Ok as some kind of stopgap measure. Maybe to be revisted with lower concurrency (tomcat thread max 20 instead of 200 ?) and actuator health probe on separate tomcat thread pool, or virtualthread and limits on the number of threads (since tomcat thread limit is removed when using virtuals threads)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To improve robustness and prevent OOMKilled errors across our environments, I propose increasing the memory limits by 25%, rounding them up as we currently do.
This should help us maintain pod memory usage around 85%, providing a reasonable safety margin for industrial operation.
I did not change forking sizing as we don't have issues with those for now.