Skip to content

springboot 3.5.11#605

Merged
AbdelHedhili merged 2 commits intomainfrom
springboot_3.5.11
Apr 1, 2026
Merged

springboot 3.5.11#605
AbdelHedhili merged 2 commits intomainfrom
springboot_3.5.11

Conversation

@AbdelHedhili
Copy link
Copy Markdown
Contributor

Signed-off-by: Abdelsalem abdelsalem.hedhili@rte-france.com

Signed-off-by: Abdelsalem <abdelsalem.hedhili@rte-france.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 23, 2026

📝 Walkthrough

Walkthrough

Updated dependency versions for MinIO from 2023-09-27 to 2025-09-07 in Docker Compose configuration and documentation, and updated Elasticsearch version from 8.15.5 to 8.19.10 in documentation.

Changes

Cohort / File(s) Summary
Dependency Version Updates
README.md, docker-compose/technical/docker-compose.technical.yml
Updated Elasticsearch from 8.15.5 to 8.19.10 in technical profile table. Updated MinIO from 2023-09-27 to 2025-09-07 in version table and Docker Compose service image tag.
🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title mentions 'springboot 3.5.11' but the actual changes are Elasticsearch and Minio version updates in technical configurations. Update the title to accurately reflect the main changes, such as 'Update Elasticsearch and Minio versions in technical profile' or similar.
Description check ❓ Inconclusive The description contains only a sign-off line with no actual description of the changes made in the pull request. Provide a meaningful description that explains what changes were made, why they were made, and their impact on the project.
✅ Passed checks (1 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Comment thread k8s/resources/state-estimation-orchestrator-server-config.yml Outdated
Comment thread k8s/resources/state-estimation-server-config.yml Outdated
Comment thread migration/migrate_parameters.log Outdated

s3-storage:
image: minio/minio:RELEASE.2023-09-27T15-22-50Z
image: minio/minio:RELEASE.2025-09-07T16-13-09Z
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why upgrade ?

Signed-off-by: Abdelsalem <abdelsalem.hedhili@rte-france.com>
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
README.md (1)

152-155: Documentation updates are consistent with docker-compose changes.

The version table correctly reflects the MinIO and Elasticsearch versions from the docker-compose file.

However, the PR title mentions "springboot 3.5.11" but the changes only update MinIO and Elasticsearch versions. Consider updating the PR title/description to accurately reflect the scope of changes, or clarify if these updates are related to a Spring Boot upgrade not visible in these files.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@README.md` around lines 152 - 155, The PR title mentions "springboot 3.5.11"
but the only changes are version updates in the README.md table (Elasticsearch
and MinIO) and no Spring Boot changes; update the PR title and/or description to
accurately reflect the actual scope (e.g., "bump Elasticsearch and MinIO
versions") or, if a Spring Boot upgrade is intended, add the corresponding
Spring Boot changes (update the spring-boot version property or build files and
any related config) so the title matches the diff; reference the README.md
version table rows for MinIO/Elasticsearch and the PR title string "springboot
3.5.11" when making the correction.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@README.md`:
- Around line 152-155: The PR title mentions "springboot 3.5.11" but the only
changes are version updates in the README.md table (Elasticsearch and MinIO) and
no Spring Boot changes; update the PR title and/or description to accurately
reflect the actual scope (e.g., "bump Elasticsearch and MinIO versions") or, if
a Spring Boot upgrade is intended, add the corresponding Spring Boot changes
(update the spring-boot version property or build files and any related config)
so the title matches the diff; reference the README.md version table rows for
MinIO/Elasticsearch and the PR title string "springboot 3.5.11" when making the
correction.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 727e4c57-4a47-4f9b-9693-ac8f791eb85b

📥 Commits

Reviewing files that changed from the base of the PR and between 3e77c27 and cb07d81.

📒 Files selected for processing (2)
  • README.md
  • docker-compose/technical/docker-compose.technical.yml

@AbdelHedhili AbdelHedhili merged commit 1e19a26 into main Apr 1, 2026
3 checks passed
@AbdelHedhili AbdelHedhili deleted the springboot_3.5.11 branch April 1, 2026 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants