Skip to content

Conversation

@benrejebmoh
Copy link
Contributor

PR Summary

Properly separate permission scope from directory scope

Signed-off-by: benrejebmoh <mohamed.ben-rejeb@rte-france.com>
Signed-off-by: benrejebmoh <mohamed.ben-rejeb@rte-france.com>
@Meklo Meklo self-requested a review November 5, 2025 15:12
@Meklo
Copy link
Contributor

Meklo commented Nov 6, 2025

Code : OK
Tests : OK
Just a quick note about copyright and maybe correcting the code smell, unrelated to your code, about subDir1 would be nice while we're at it

Signed-off-by: benrejebmoh <mohamed.ben-rejeb@rte-france.com>
Signed-off-by: benrejebmoh <mohamed.ben-rejeb@rte-france.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 6, 2025

@benrejebmoh benrejebmoh merged commit 1516ad0 into main Nov 6, 2025
4 checks passed
@benrejebmoh benrejebmoh deleted the separate-permission-scope branch November 6, 2025 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants