Add Limits properties to TwoWindingsTransformer and Line Infos Mapper #295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: basseche <bassel.el-cheikh_externe@rte-france.com>
basseche
changed the title
basseche
changed the title
Signed-off-by: basseche <bassel.el-cheikh_externe@rte-france.com>
Signed-off-by: basseche <bassel.el-cheikh_externe@rte-france.com>
basseche
force-pushed
the
tagProperties_LimitSets
branch
from
449e438 to
6a30a1f
Compare
Signed-off-by: basseche <bassel.el-cheikh_externe@rte-france.com>
basseche
force-pushed
the
tagProperties_LimitSets
branch
from
be98f5c to
78f257c
Compare
basseche
force-pushed
the
tagProperties_LimitSets
branch
from
78f257c to
13f1fa7
Compare
EtienneLt
reviewed
Oct 23, 2025
Contributor
EtienneLt
left a comment
EtienneLt
left a comment
There was a problem hiding this comment.
Can you add a test with properties in it (tests are with empty list of properties)
src/main/java/org/gridsuite/network/map/dto/mapper/BranchInfosMapper.java
Outdated
Show resolved
Hide resolved
src/main/java/org/gridsuite/network/map/dto/mapper/BranchInfosMapper.java
Outdated
Show resolved
Hide resolved
src/main/java/org/gridsuite/network/map/dto/mapper/BranchInfosMapper.java
Outdated
Show resolved
Hide resolved
flomillot
reviewed
Oct 23, 2025
src/main/java/org/gridsuite/network/map/dto/mapper/BranchInfosMapper.java
Outdated
Show resolved
Hide resolved
src/test/java/org/gridsuite/network/map/dto/mapper/BranchInfosMapperTest.java
Show resolved
Hide resolved
src/test/java/org/gridsuite/network/map/dto/mapper/BranchInfosMapperTest.java
Show resolved
Hide resolved
basseche
force-pushed
the
tagProperties_LimitSets
branch
from
ec218be to
c2344e6
Compare
Signed-off-by: basseche <bassel.el-cheikh_externe@rte-france.com>
basseche
force-pushed
the
tagProperties_LimitSets
branch
from
c2344e6 to
0faf0fa
Compare
|
flomillot
approved these changes
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.