refactor topology infos and create new endpoint #298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>
etiennehomer
reviewed
Oct 8, 2025
src/main/java/org/gridsuite/network/map/dto/utils/TopologyUtils.java
Outdated
Show resolved
Hide resolved
ghazwarhili
reviewed
Oct 14, 2025
src/main/java/org/gridsuite/network/map/NetworkMapController.java
Outdated
Show resolved
Hide resolved
src/main/java/org/gridsuite/network/map/NetworkMapController.java
Outdated
Show resolved
Hide resolved
src/main/java/org/gridsuite/network/map/dto/definition/topology/TopologyInfos.java
Outdated
Show resolved
Hide resolved
src/main/java/org/gridsuite/network/map/dto/definition/topology/TopologyInfos.java
Outdated
Show resolved
Hide resolved
src/main/java/org/gridsuite/network/map/dto/definition/topology/TopologyInfos.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>
ghazwarhili
requested changes
Oct 20, 2025
src/main/java/org/gridsuite/network/map/dto/definition/voltagelevel/VoltageLevelFormInfos.java
Show resolved
Hide resolved
Contributor
|
#303 I'd like to propose this PR for the refacto |
voltage level form refacto
Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>
ghazwarhili
approved these changes
Oct 30, 2025
etiennehomer
requested changes
Nov 4, 2025
| @GetMapping(value = "/networks/{networkUuid}/voltage-levels/{voltageLevelId}/feeder-bays-and-bus-bar-sections", produces = APPLICATION_JSON_VALUE) | ||
| @Operation(summary = "get feeder bays and bus bar sections information") | ||
| @ApiResponses(value = {@ApiResponse(responseCode = "200", description = " feeder bays and bus bar sections information retrieved")}) | ||
| public FeederBaysBusBarSectionsInfos getMoveVoltageLevelFeederBaysInfos(@Parameter(description = "Network UUID") @PathVariable("networkUuid") UUID networkUuid, |
Contributor
There was a problem hiding this comment.
Suggested change
| public FeederBaysBusBarSectionsInfos getMoveVoltageLevelFeederBaysInfos(@Parameter(description = "Network UUID") @PathVariable("networkUuid") UUID networkUuid, | |
| public FeederBaysBusBarSectionsInfos getFeederBaysInfos(@Parameter(description = "Network UUID") @PathVariable("networkUuid") UUID networkUuid, |
| .open(sw.isOpen()) | ||
| .build())); | ||
| return switchInfosList; | ||
| public FeederBaysBusBarSectionsInfos getMoveVoltageLevelFeederBaysInfos(UUID networkUuid, String voltageLevelId, String variantId) { |
Contributor
There was a problem hiding this comment.
Suggested change
| public FeederBaysBusBarSectionsInfos getMoveVoltageLevelFeederBaysInfos(UUID networkUuid, String voltageLevelId, String variantId) { | |
| public FeederBaysBusBarSectionsInfos getFeederBaysInfos(UUID networkUuid, String voltageLevelId, String variantId) { |
Contributor
There was a problem hiding this comment.
It's better that the network-map-server doesn't have network-modification notions
| builder.isBusbarSectionPositionFound(vlTopologyInfos.isBusbarSectionPositionFound()); | ||
| builder.busBarSectionInfos(vlTopologyInfos.getBusBarSectionInfosGrouped()); | ||
| builder.feederBaysInfos(getFeederBaysInfos(voltageLevel)); | ||
| VoltageLevelFormInfos busBarSectionsInfos = getVoltageLevelBusBarSectionsInfos(voltageLevel); |
Contributor
There was a problem hiding this comment.
Weird code here. If we work with VoltageLevelFormInfos only, it's cleaner to do something like:
voltageLevelFormInfos.setTopologyInfos() in replacement of all this code
| var extension = bbs.getExtension(BusbarSectionPosition.class); | ||
| if (extension == null) { | ||
| return VoltageLevelFormInfos.builder() | ||
| .busbarCount(1) |
Contributor
There was a problem hiding this comment.
When the extension is null, we return the default values
VoltageLevelFormInfos.builder()
.busbarCount(1)
.sectionCount(1)
.topologyKind(NODE_BREAKER)
.switchKinds(Collections.emptyList())
.isSymmetrical(false)
.build();
src/main/java/org/gridsuite/network/map/dto/mapper/VoltageLevelInfosMapper.java
Outdated
Show resolved
Hide resolved
etiennehomer
approved these changes
Nov 5, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.