feat(balances-adjustment): use current thread for loadflow #131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joris Mancini <joris.mancini_externe@rte-france.com>
TheMaskedTurtle
force-pushed
the
propagate-context
branch
2 times, most recently
from
5b26299 to
d04d304
Compare
Signed-off-by: Joris Mancini <joris.mancini_externe@rte-france.com>
TheMaskedTurtle
force-pushed
the
propagate-context
branch
from
d04d304 to
36a4fde
Compare
|
benrejebmoh
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Previously we were propagating ComputationManager coming from lib caller, but in fact it was always called with LocalComputationManager.getDefault() coming from default implementations of apply in AbstractNetworkModification.
Here, in the case of balances-adjustment, we actually want to just run the loadflows in the same thread as the balances-adjustment, and it's the caller responsibility to be set in the proper thread already.
Besides, it will automatically use the contextualised thread in network-modification-server. So, it will as consequence fix the issue where in the server balances-adjustment logs were properly contextualised but not the loadflow ones.