Skip to content

fix: terminal cursor style + Cmd+K clear#91

Merged
grimmerk merged 1 commit intomainfrom
fix/terminal-blinking-cursor-and-cmd-k-behavior
Apr 4, 2026
Merged

fix: terminal cursor style + Cmd+K clear#91
grimmerk merged 1 commit intomainfrom
fix/terminal-blinking-cursor-and-cmd-k-behavior

Conversation

@grimmerk
Copy link
Copy Markdown
Owner

@grimmerk grimmerk commented Apr 4, 2026

  • White non-blinking block cursor (matching iTerm2 style)
  • Cmd+K clears terminal screen

🤖 On behalf of @grimmerk — generated with Claude Code

Summary by CodeRabbit

  • New Features

    • Cmd+K keyboard shortcut to clear the terminal screen.
    • Shift+Enter inserts a newline for multi-line terminal input.
  • Bug Fixes

    • Terminal cursor now appears as a white, non-blinking block to match expected rendering.
  • Chores

    • Package version bumped to 1.0.61.
  • Documentation

    • Changelog updated with the 1.0.61 release notes.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 4, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 5ac032bb-b656-4f6a-b1ea-9c98927605d9

📥 Commits

Reviewing files that changed from the base of the PR and between fe6784c and eb33da0.

📒 Files selected for processing (3)
  • CHANGELOG.md
  • package.json
  • src/terminal-tab.tsx

📝 Walkthrough

Walkthrough

Bumps package to 1.0.61 and adds a ## 1.0.61 changelog section; changes terminal cursor to a non-blinking silver block; adds Cmd+K to clear the terminal and Shift+Enter to send a newline to terminal input.

Changes

Cohort / File(s) Summary
Changelog & Version
CHANGELOG.md, package.json
Add ## 1.0.61 changelog entry and bump version to 1.0.61.
Terminal UI & Key Handling
src/terminal-tab.tsx
Set xterm cursor color to #C0C0C0 and disable blinking; handle Cmd+K to call term.clear() and Shift+Enter to inject \x0a (newline) into the terminal input and prevent default propagation.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Poem

🐰 I hop on keys and render with care,
A silver block sits steady in my lair.
Cmd+K clears the view so bright,
Shift+Enter sends a line just right.
Version 1.0.61 — a quiet, nimble hare. ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately captures two of the three main changes: cursor style fix and Cmd+K terminal clear functionality, which are the primary modifications to terminal behavior.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/terminal-blinking-cursor-and-cmd-k-behavior

Comment @coderabbitai help to get the list of available commands and usage tips.

@grimmerk grimmerk force-pushed the fix/terminal-blinking-cursor-and-cmd-k-behavior branch from 80b67c7 to caf61eb Compare April 4, 2026 08:44
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@src/terminal-tab.tsx`:
- Line 42: The Cmd+K shortcut check in the keyboard handler is case-sensitive
and misses Shift+K; update the conditional that currently checks e.key === 'k'
(in the handler that calls term.clear()) to normalize the key before comparison
(e.g., compare e.key.toLowerCase() === 'k' or use a safe lowercase call) while
keeping the e.type === 'keydown' and e.metaKey checks intact so Shift-modified
keypresses are recognized.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: c518c5ca-0a5d-4904-bd1a-6faae6029eae

📥 Commits

Reviewing files that changed from the base of the PR and between 80b67c7 and caf61eb.

📒 Files selected for processing (3)
  • CHANGELOG.md
  • package.json
  • src/terminal-tab.tsx
✅ Files skipped from review due to trivial changes (2)
  • CHANGELOG.md
  • package.json

Comment thread src/terminal-tab.tsx
@grimmerk grimmerk force-pushed the fix/terminal-blinking-cursor-and-cmd-k-behavior branch 2 times, most recently from 24a184c to fe6784c Compare April 4, 2026 08:59
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@grimmerk grimmerk force-pushed the fix/terminal-blinking-cursor-and-cmd-k-behavior branch from fe6784c to eb33da0 Compare April 4, 2026 09:02
@grimmerk grimmerk merged commit 234708b into main Apr 4, 2026
@coderabbitai coderabbitai Bot mentioned this pull request Apr 8, 2026
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant