Make namespace a required Cacheables option#13
Merged
Conversation
Promotes `namespace` from optional to required on `CacheablesOptions` to prevent silent key collisions when adapters are shared across instances. Drops the undefined branch in `#fullKey` and removes the verbatim-key behaviour test along with related README/test updates. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The latest published version on npm is v2.0.0; the breaking changes land in v3, not v4. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Reconciles the required-namespace change with the bucket rename landed on next (Cacheables → Cacheable, IStorageAdapter → IBucket, MemoryAdapter → MemoryBucket, adapters → buckets). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
namespacefrom optional to required onCacheablesOptionsto eliminate the silent key-collision footgun when multipleCacheablesinstances share an adapter.#fullKey()(no moreundefinedbranch) and update tests, README examples, and the v3→v4 migration notes accordingly.Test plan
npm test(52/52 pass)npm run typecheckclean🤖 Generated with Claude Code