Add grisp.io custom protocol version header#53
Conversation
|
I can't reproduce the CT error :( |
|
I forgot to push some changes in jarl... |
sylane
force-pushed
the
sylane/add-proto-version
branch
from
7e3790d to
bc14c9e
Compare
- Remove invalid configuration. - Fix dialyzer spec. - Add option to limit the number of connection retries, mostly for testing use-cases that will always fail to connect. - Implemente wait_connected in the client to support reaching maximum connection retries and get the last known error.
sylane
force-pushed
the
sylane/add-proto-version
branch
from
a5d38da to
fb7616d
Compare
| catch exit:noproc -> false | ||
| end. | ||
|
|
||
| wait_connected(Timeout) -> |
There was a problem hiding this comment.
Wouldn't it make more sense to adjust is_connected to include a timeout instead of adding yet another function for more or less the same feature? Is there a reason that we need both?
There was a problem hiding this comment.
is_connected return true or false right away, it doesn't wait for the connection to either be established or to fail because the maximum number of retries has been reached. Maybe we don't need is_connected, but it is definitely not the same.
There was a problem hiding this comment.
That was my question: Do we need both?
There was a problem hiding this comment.
The cover a different use-case, I needed to add wait_connected, but didn't want to change grisp_connect API that is exposing is_connected.
3 participants
Add grisp.io protocol versioning
testing use-cases that will always fail to connect.
connection retries and get the last known error.