Skip to content

support grisp_tools 2#7

Merged
ziopio merged 9 commits intogrisp:masterfrom
tonnenpinguin:fix/support-grisp-2
Mar 19, 2024
Merged

support grisp_tools 2#7
ziopio merged 9 commits intogrisp:masterfrom
tonnenpinguin:fix/support-grisp-2

Conversation

@tonnenpinguin
Copy link
Copy Markdown
Contributor

@tonnenpinguin tonnenpinguin commented Mar 16, 2024

Building on top of @LostKobrakai and @ziopio 's work this is now fully functional.

I dropped all distillery related code, changed the logic that calculates the apps to use the source directory. This is required because those directories are used to assemble the overlays and the build output directories don't include those files.

I also updated the readme, as the paths mentioned don't work, since grisp_tools is very picky about the paths being used.

And finally I also updated the grisp.ini.mustache erl arguments to get things working with Elixir 1.16 & OTP 26 (the flags required for iex changed) and to deal with the fact that mix releases rely on a boot_var RELEASE_LIB to be set

@ziopio ziopio self-requested a review March 18, 2024 10:02
Copy link
Copy Markdown
Member

@ziopio ziopio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First of all thanks very much for this contribution!
I think we can just set the bar to use elixir 1.16 and OTP 26 and update the references to point to such versions.
I also needed to add xmerl to the mix_grisp applications sections, otherwise mix does not load xmerl and grisp_tools fails.

  def application() do
    [
      extra_applications: [:logger, :xmerl]
    ]
  end

Then I will squash and merge.

Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread lib/mix/tasks/grisp/deploy.ex Outdated
Comment thread mix.exs Outdated
Comment thread mix.exs Outdated
@tonnenpinguin
Copy link
Copy Markdown
Contributor Author

Thanks for the review @ziopio
I addressed all your comments 🙂

@tonnenpinguin tonnenpinguin requested a review from ziopio March 18, 2024 11:48
@ziopio ziopio merged commit 3ab133f into grisp:master Mar 19, 2024
@tonnenpinguin tonnenpinguin deleted the fix/support-grisp-2 branch March 19, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants