support grisp_tools 2#7
Merged
ziopio merged 9 commits intogrisp:masterfrom Mar 19, 2024
Merged
Conversation
ziopio
requested changes
Mar 18, 2024
Member
There was a problem hiding this comment.
First of all thanks very much for this contribution!
I think we can just set the bar to use elixir 1.16 and OTP 26 and update the references to point to such versions.
I also needed to add xmerl to the mix_grisp applications sections, otherwise mix does not load xmerl and grisp_tools fails.
def application() do
[
extra_applications: [:logger, :xmerl]
]
end
Then I will squash and merge.
Contributor
Author
|
Thanks for the review @ziopio |
ziopio
approved these changes
Mar 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building on top of @LostKobrakai and @ziopio 's work this is now fully functional.
I dropped all distillery related code, changed the logic that calculates the
appsto use the source directory. This is required because those directories are used to assemble the overlays and the build output directories don't include those files.I also updated the readme, as the paths mentioned don't work, since
grisp_toolsis very picky about the paths being used.And finally I also updated the
grisp.ini.mustacheerl arguments to get things working with Elixir 1.16 & OTP 26 (the flags required for iex changed) and to deal with the fact that mix releases rely on a boot_varRELEASE_LIBto be set