fix: Missing translations in Admin panel #1524
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuhabitela
suggested changes
Mar 20, 2025
Collaborator
manuhabitela
left a comment
manuhabitela
left a comment
There was a problem hiding this comment.
Thanks Grégoire :)
hexaltation
moved this from Needs feedback
to In Progress
in French administration Board
hexaltation
moved this from In Progress
to Needs Internal Feedback
in French administration Board
fflorent
force-pushed
the
admin-panel-translation
branch
from
b4215c8 to
e4b66b9
Compare
hexaltation
force-pushed
the
admin-panel-translation
branch
from
de79d6e to
addb8bd
Compare
manuhabitela
approved these changes
Aug 19, 2025
Collaborator
manuhabitela
left a comment
manuhabitela
left a comment
There was a problem hiding this comment.
Thanks @hexaltation 🤝
hexaltation
force-pushed
the
admin-panel-translation
branch
from
ad6b75c to
7af847e
Compare
RaywanS
moved this from Needs Internal Feedback
to Needs feedback
in French administration Board
hexaltation
force-pushed
the
admin-panel-translation
branch
from
7af847e to
2b2d4a2
Compare
This PR only does partially it only fixes client side strings. Some more job has to be done as some chains are generated server side, at least in `app/server/lib/BootProbes.ts`
hexaltation
force-pushed
the
admin-panel-translation
branch
from
87da085 to
027eee9
Compare
paulfitz
approved these changes
Sep 2, 2025
github-project-automation
bot
moved this from Needs feedback
to Done
in French administration Board
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Some strings are not translated in AdminPanel.
Proposed solution
This PR only does partially it only fixes client side strings.
Out of scope
Some more job has to be done as some chains are generated server side, at least in
app/server/lib/BootProbes.tsAnd it seems to use some keys of objects as string to be translated, which will need some more job.
Has this been tested?