(right panel) making subtabs styling easier to understand #1635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuhabitela
force-pushed
the
better-subtabs-styles
branch
from
98c99aa to
9c0d303
Compare
manuhabitela
commented
May 23, 2025
- the current sub tab text is bold, like the current tab - inactive tabs are grayed out. before, they were green, making it a bit weird to understand (it's in the primary color, but it's inactive, kind of opposite directions) - active tab has bigger bottom border all these changes make it easier at a glance to understand the current sub tab figma design: https://www.figma.com/design/wcpetFt6aOKzTszcvPPWLQ/-05-24--Grist-Design?node-id=2761-141496&t=RAUSxMNi7Gk7xLJ3-4
manuhabitela
force-pushed
the
better-subtabs-styles
branch
from
9c0d303 to
2984727
Compare
Contributor
|
Deployed commit |
georgegevoian
approved these changes
May 28, 2025
Contributor
georgegevoian
left a comment
georgegevoian
left a comment
There was a problem hiding this comment.
Thanks @manuhabitela.
Collaborator
Author
|
Thanks George :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
As mentioned in related issue #1299, current right panel subtabs are a tiny bit weird to understand given the inactive tabs are the primary-colored ones.
Proposed solution
Here is some code that implements @lusebille's design.
Related issues
Fixes #1299.
Has this been tested?
No tests were added as those are purely visual changes. I manually verified on Firefox, Chrome, Edge, Safari on macOS and iOS, and Chrome on Android.
Screenshots / Screencasts
Before:
After:
subtabs.mp4