Tests: move some functions from gristUtils to gristWebDriverUtils
#1636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of refactor to sync with grist-widget.
Part of refactor to sync with grist-widget.
Part of refactor to sync with grist-widget.
…Utils Part of refactor to sync with grist-widget. Note that this does a few more things because it's the copy coming from the grist-widget repository.
Part of refactor to sync with grist-widget.
Part of refactor to sync with grist-widget.
Part of refactor to sync with grist-widget.
Part of refactor to sync with grist-widget.
Part of refactor to sync with grist-widget.
Part of refactor to sync with grist-widget.
jordigh
force-pushed
the
jordigh/split-grist-utils
branch
3 times, most recently
from
a9bab44 to
ba8d440
Compare
Part of refactor to sync with grist-widget. This also moves associated functions.
…verUtils Part of refactor to sync with grist-widget.
jordigh
force-pushed
the
jordigh/split-grist-utils
branch
from
ba8d440 to
5ad9b1d
Compare
berhalak
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We need to resynch our test harness between
grist-coreandgrist-widget. This is a first step to move intogristWebDriverUtilsthe relevant tools (cf. #154 1ingrist-widget).Proposed solution
Move some needed functions into
gristWebDriverUtilsso it can be properly shared verbatim betweengrist-coreandgrist-widget.Related issues
grist-widgetHas this been tested?