Skip to content

Fix for the May/March ambiguity.#183

Merged
kermitt2 merged 1 commit intogrobidOrg:masterfrom
aoboturov:fix/may-march-ambiguity
May 16, 2017
Merged

Fix for the May/March ambiguity.#183
kermitt2 merged 1 commit intogrobidOrg:masterfrom
aoboturov:fix/may-march-ambiguity

Conversation

@aoboturov
Copy link
Contributor

@aoboturov aoboturov commented May 9, 2017

There are two things in this commit:

  1. Patterns are simplified to change (J|j) to [Jj] which accordingly to Intellij should work faster :)
  2. Months patterns are matched till the end of string, this would prevent the test "testMayAndMarchOverlap" to fail for May because it would match ma for Pattern mar first.

@kermitt2 kermitt2 merged commit 2ab2b23 into grobidOrg:master May 16, 2017
@kermitt2
Copy link
Collaborator

kermitt2 commented May 16, 2017

Many thanks for the PR !

@kermitt2 kermitt2 mentioned this pull request Dec 21, 2018
Open
de-code pushed a commit to elifesciences/grobid that referenced this pull request Nov 29, 2019
@kermitt2
Merge pull request grobidOrg#183 from aoboturov/fix/may-march-ambiguity
ad7a930 
Fix for the May/March ambiguity.

Former-commit-id: 2ab2b23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aoboturov @kermitt2