Conversation
de-code
reviewed
Oct 12, 2020
de-code
reviewed
Oct 12, 2020
grobid-core/src/main/java/org/grobid/core/utilities/GrobidProperties.java
Outdated
Show resolved
Hide resolved
de-code
reviewed
Oct 12, 2020
grobid-core/src/main/java/org/grobid/core/utilities/GrobidProperties.java
Show resolved
Hide resolved
Collaborator
|
Looking good too me. Thank you for doing that. |
Member
Author
|
Thanks @de-code for checking it out. I move it to "ready". |
Member
Author
|
(I suggest to also apply #620, as it's touching a similar part) |
Member
Author
|
@de-code Thanks for the feedback. I pushed a fix. |
Collaborator
|
Very readable, tested and it fixes the problem raised in PR #559, thanks a lot! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added two new methods in the GrobidProperties that allow to:
grobid.crf.engineproperty.When running LibraryLoader.load() instead of checking only the value of
grobid.crf.engineI consider the list of specified engines.