Skip to content

Fixing problem in PR 559#648

Merged
kermitt2 merged 3 commits intomasterfrom
bugfix/problem-pr-559
Oct 13, 2020
Merged

Fixing problem in PR 559#648
kermitt2 merged 3 commits intomasterfrom
bugfix/problem-pr-559

Conversation

@lfoppiano
Copy link
Member

@lfoppiano lfoppiano commented Oct 12, 2020

I've added two new methods in the GrobidProperties that allow to:

  • get all the engines selected individually in the configuration
  • get all possible engines needed (result of the above point and the engine selected in the grobid.crf.engine property.

When running LibraryLoader.load() instead of checking only the value of grobid.crf.engine I consider the list of specified engines.

@lfoppiano lfoppiano added the bug From Hemiptera and especially its suborder Heteroptera label Oct 12, 2020
@lfoppiano lfoppiano marked this pull request as draft October 12, 2020 02:12
@coveralls
Copy link

coveralls commented Oct 12, 2020

Coverage Status

Coverage increased (+0.02%) to 38.188% when pulling adc0a94 on bugfix/problem-pr-559 into b0560b5 on master.

@de-code
Copy link
Collaborator

de-code commented Oct 12, 2020

Looking good too me. Thank you for doing that.

@lfoppiano lfoppiano marked this pull request as ready for review October 12, 2020 08:39
@lfoppiano
Copy link
Member Author

Thanks @de-code for checking it out. I move it to "ready".

@lfoppiano
Copy link
Member Author

(I suggest to also apply #620, as it's touching a similar part)

@lfoppiano
Copy link
Member Author

@de-code Thanks for the feedback. I pushed a fix.

@kermitt2
Copy link
Collaborator

Very readable, tested and it fixes the problem raised in PR #559, thanks a lot!
It's much easier with this fix to specify a couple of models with DeLFT, the rest with Wapiti - which is the best config currently in term of accuracy (the 2 DeLFT models to use for this being the citation model and the affiliation-address model).

@kermitt2 kermitt2 merged commit 77fc1ad into master Oct 13, 2020
@lfoppiano lfoppiano deleted the bugfix/problem-pr-559 branch June 9, 2021 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug From Hemiptera and especially its suborder Heteroptera

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants