feat: add support for script-based sort#10
Merged
Conversation
Member
Author
|
Wrote a sample test case locally, looks like the current implementation is considering the old existing sort parameters from the old request. Let's discuss how we can solve this out. |
harshit98
commented
May 15, 2025
17sushmita
reviewed
May 20, 2025
17sushmita
reviewed
May 20, 2025
17sushmita
reviewed
May 20, 2025
17sushmita
reviewed
May 20, 2025
17sushmita
reviewed
May 20, 2025
17sushmita
reviewed
May 20, 2025
17sushmita
reviewed
May 20, 2025
17sushmita
approved these changes
May 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
SortOptionInterface:SortOptionto enable different types of sorting options.rawSortFieldandScriptSortParams.ScriptSortParamsto support script-based sorting, including its mapping to Elasticsearch-compatible formats.ClearSort,SortScript,SortRaw, andSortByScriptto enhance flexibility in specifying sort criteria._score).ClearSortwill help us avoid accumulation and re-use of old sorting options from previous request.