Skip to content

Conversation

@ParadoxGuitarist
Copy link
Collaborator

Brief Changelog:

  • --version flag to assist with end user support (we can make sure we're running the current version of jamf2snipe)
  • Better logging when missing required settings from settings.conf
  • Token Bearer Auth (Support for Bearer Token authentication #80)
  • Gets a token against the Jamf API as part of the dryrun, which has the added bonus of being another test in use with --dryrun
  • Bug fix where the script would stop if MDM didn't have a serial number in the jamf entry yet.

@uberbrady
Copy link
Member

This looks GREAT @ParadoxGuitarist - thank you so much! I've been anxious about the new token thingee for a while now - I'm so stoked that you've gone and implemented it!

I'd love to get some feedback from some of the people who use this software before we take the PR, but it looks great to me so far!

@ParadoxGuitarist
Copy link
Collaborator Author

Thanks @uberbrady :)

For what it's worth, at least one user has ran it so far and it was fine until the summary where it threw an error because I missed a variable that got renamed. (on the very last line. Ugh)

I know how difficult it can be to get others to test it fully. There's a lot of wisdom in waiting for another person to test it though, I, on the other hand, can just walk away. Just wanted to make sure you had all the details. 🙂

Copy link
Member

@uberbrady uberbrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, as I mentioned earlier! I approve :)

@dstocking
Copy link

dstocking commented Oct 12, 2022

FWIW @ParadoxGuitarist, I've also tested this version and it's working for me!

Thanks @uberbrady :)

For what it's worth, at least one user has ran it so far and it was fine until the summary where it threw an error because I missed a variable that got renamed. (on the very last line. Ugh)

I know how difficult it can be to get others to test it fully. There's a lot of wisdom in waiting for another person to test it though, I, on the other hand, can just walk away. Just wanted to make sure you had all the details. 🙂

@snipe snipe merged commit 8da3c99 into main Oct 12, 2022
@snipe snipe deleted the devel branch October 12, 2022 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants