Initial stab at middelware that reformats SCIM responses #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I've tested all three of:
And it works as expected in all three cases. |
uberbrady
force-pushed
the
postprocessing_middleware
branch
from
5b4ad1a to
7754ef4
Compare
dmyers
reviewed
Nov 17, 2022
| if(config('scim.standards_compliance')) { | ||
| $response_content = json_decode($response->content()); | ||
|
|
||
| if (!$response_content->totalResults) { |
There was a problem hiding this comment.
@uberbrady This throws an undefined property error for me when viewing a user resource (ex: /scim/v2/Users/1).
ErrorException: Undefined property: stdClass::$totalResultsI think it should be this:
if (!property_exists($response_content, 'totalResults')) {
dmyers
reviewed
Nov 17, 2022
|
|
||
| if (!$response_content->totalResults) { | ||
| $response->setContent(json_encode(undefault_schema($response_content))); | ||
| } else { |
There was a problem hiding this comment.
I'd recommend this else be changed to make sure the Resources property was in the response in case other routes in this middleware might cause undefined property to be accessed.
} else if (property_exists($response_content, 'Resources')) {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not 100% on this yet, but this seems to basically do the trick - it takes any SCIM response and yanks out any elements that are from a 'core' schema - which shouldn't be put into a sub-block, but should actually be in the 'root' level of the returned JSON. This handles that for individual responses, as well as list-responses.
I've only really tested against grabbing a user listing or grabbing a single user, or doing a user-create.