Fixed: Okta SCIM PUT for an existing user would not overwrite Enterprise attributes #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snipe
approved these changes
Jan 12, 2023
Member
snipe
left a comment
snipe
left a comment
There was a problem hiding this comment.
I don't have a good way to test this, but seems ok
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, specifically, it looks like Okta does a PUT on a Userresource (e.g.
/scim/v2/Users/123) to replace all of its values with what isPUTwhen an update to a user record is made on the Okta side.While that mostly works, it seems like "Enterprise" attributes (such as department and employee number) would be silently ignored.
This change allows the 'flatten' function to become aware of the other namespaces present in the user and to continue to update elements that are outside of the "regular" user namespace.