Issue upgrading to v8.4.1 (Permission Issue?)

[synergy34]

Howdy Folks.

Seem to be running into an issue when upgrading our Snipe-IT instance from v8.4.0 to v8.4.1.

After "upgrading" to v8.4.1, it is still on v8.4.0.

I have noticed this:

√ ERROR Failed to clear cache. Make sure you have the appropriate permissions.

• Server: Ubuntu
• Installation Method: .sh script.

Here is the full output from the CLI:

admin@SERVERNAME:~$ cd /var/www/html/snipeit/
admin@SERVERNAME:/var/www/html/snipeit$ git checkout origin/master upgrade.php
Updated 0 paths from 0e2db330dd
admin@SERVERNAME:/var/www/html/snipeit$ php upgrade.php
--------------------------------------------------------
WELCOME TO THE SNIPE-IT UPGRADER!
--------------------------------------------------------

This script will attempt to:

- validate some very basic .env file settings
- check your PHP version and extension requirements
- check directory permissions
- change your 'git remote' to the new Snipe-IT GitHub URL
- do a git pull to bring you to the latest version
- run composer install to get your vendors up to date
- run a backup
- run migrations to get your schema up to date
- clear out old cache settings

Launching using branch: master
Found PHP requirements, will check for PHP > 8.2.0 and < 8.5.0
Proceed with upgrade? [y/N]: y

--------------------------------------------------------
STEP 1: Checking .env file:
--------------------------------------------------------

√ Your .env file is located at /var/www/html/snipeit/.env
√ Your APP_KEY is not blank.
√ Your APP_URL is not null or blank. It is set to https://servername.local
√ Your APP_URL is set to https://servername.local and starts with the protocol (https:// or http://)
√ Your APP_URL (https://servername.local) does not have a trailing slash.

--------------------------------------------------------
STEP 2: Checking PHP requirements: (Required PHP >=8.2.0 - <8.5.0)
--------------------------------------------------------

√ Current PHP version: (8.3.6) is at least 8.2.0 and less than 8.5.0! Continuing...
FYI: The php.ini used by this PHP is: /etc/php/8.3/cli/php.ini

Checking Required PHP extensions...

√ bcmath is installed!
√ curl is installed!
√ exif is installed!
√ fileinfo is installed!
√ gd is installed!
√ json is installed!
√ ldap is installed!
√ mbstring is installed!
√ mysqli is installed!
√ openssl is installed!
√ PDO is installed!
√ sodium is installed!
√ tokenizer is installed!
√ xml is installed!
√ zip is installed!

--------------------------------------------------------
STEP 3: Checking directory permissions:
--------------------------------------------------------

√ /var/www/html/snipeit/bootstrap/cache is writable
√ /var/www/html/snipeit/storage is writable
√ /var/www/html/snipeit/storage/logs is writable
√ /var/www/html/snipeit/storage/logs/laravel.log is writable
√ /var/www/html/snipeit/storage/framework is writable
√ /var/www/html/snipeit/storage/framework/cache is writable
√ /var/www/html/snipeit/storage/framework/sessions is writable
√ /var/www/html/snipeit/storage/framework/views is writable
√ /var/www/html/snipeit/storage/app is writable
√ /var/www/html/snipeit/storage/app/backups is writable
√ /var/www/html/snipeit/storage/app/backup-temp is writable
√ /var/www/html/snipeit/storage/private_uploads is writable
√ /var/www/html/snipeit/public/uploads is writable

--------------------------------------------------------
STEP 4: Pulling latest from Git (master branch):
--------------------------------------------------------

Git is installed.
remote: Enumerating objects: 15844, done.
remote: Counting objects: 100% (6961/6961), done.
remote: Compressing objects: 100% (157/157), done.
remote: Total 15844 (delta 6856), reused 6805 (delta 6804), pack-reused 8883 (from 2)
Receiving objects: 100% (15844/15844), 11.14 MiB | 19.34 MiB/s, done.
Resolving deltas: 100% (10166/10166), completed with 2232 local objects.
From https://github.com/grokability/snipe-it
 * [new branch]            #18736-add-cumulative-cost-of-an-asset-with-maintenances -> origin/#18736-add-cumulative-cost-of-an-asset-with-maintenances
 * [new branch]            _view-user-address-permission-take-2 -> origin/_view-user-address-permission-take-2
 * [new branch]            advanced-search-for-licenses -> origin/advanced-search-for-licenses
 * [new branch]            audit-visibility-fix    -> origin/audit-visibility-fix
 * [new branch]            better-sanitize-ordering-by-numeric -> origin/better-sanitize-ordering-by-numeric
 * [new branch]            copilot/sub-pr-18740-again -> origin/copilot/sub-pr-18740-again
   2ed32612b9..21d030db26  develop                 -> origin/develop
 * [new branch]            display-effective-permissions -> origin/display-effective-permissions
 * [new branch]            fix-oauth-perms-script  -> origin/fix-oauth-perms-script
   dbe998d9cf..1c5d81cb04  master                  -> origin/master
 * [new branch]            rename-assetstatus-to-statuslabel -> origin/rename-assetstatus-to-statuslabel
 * [new branch]            small-permission-tweaks -> origin/small-permission-tweaks
 * [new branch]            temp-downgrade-passport -> origin/temp-downgrade-passport
 * [new branch]            view-user-address-permission -> origin/view-user-address-permission
 * [new tag]               v8.4.1                  -> v8.4.1
Already on 'master'
There is no tracking information for the current branch.
Please specify which branch you want to merge with.
See git-pull(1) for details.

    git pull <remote> <branch>

If you wish to set tracking information for this branch you can do so with:

    git branch --set-upstream-to=origin/<branch> master

-- No local changes to save
-- --
--------------------------------------------------------
STEP 5: Cleaning up old cached files:
--------------------------------------------------------

√ No bootstrap/cache/compiled.php, so nothing to delete.
√ Deleting bootstrap/cache/services.php. It is no longer used.
√ No bootstrap/cache/config.php, so nothing to delete.
√ No vendor/symfony/translation/TranslatorInterface.php, so nothing to delete.

--------------------------------------------------------
STEP 6: Updating composer dependencies:
(This may take a moment.)
--------------------------------------------------------

-- Running the app in production mode.
-- We couldn't find a local composer.phar. No worries, trying globally.
Since you are running composer globally, we won't try to update it for you.
If you run into issues with this step, try running `composer self-update`
before running this updater again

Installing dependencies from lock file
Verifying lock file contents can be installed on current platform.
Nothing to install, update or remove
Package laravelcollective/html is abandoned, you should avoid using it. Use spatie/laravel-html instead.
Generating optimized autoload files
Warning: Ambiguous class resolution, "League\Flysystem\AwsS3V3\AwsS3V3AdapterTest" was found in both "/var/www/html/snipeit/vendor/league/flysystem-aws-s3-v3/AwsS3V3AdapterTest.php" and "/var/www/html/snipeit/vendor/league/flysystem/src/AwsS3V3/AwsS3V3AdapterTest.php", the first will be used.
Warning: Ambiguous class resolution, "League\Flysystem\AwsS3V3\S3ClientStub" was found in both "/var/www/html/snipeit/vendor/league/flysystem-aws-s3-v3/S3ClientStub.php" and "/var/www/html/snipeit/vendor/league/flysystem/src/AwsS3V3/S3ClientStub.php", the first will be used.
Warning: Ambiguous class resolution, "League\Flysystem\AwsS3V3\AwsS3V3Adapter" was found in both "/var/www/html/snipeit/vendor/league/flysystem-aws-s3-v3/AwsS3V3Adapter.php" and "/var/www/html/snipeit/vendor/league/flysystem/src/AwsS3V3/AwsS3V3Adapter.php", the first will be used.
Warning: Ambiguous class resolution, "League\Flysystem\AwsS3V3\VisibilityConverter" was found in both "/var/www/html/snipeit/vendor/league/flysystem-aws-s3-v3/VisibilityConverter.php" and "/var/www/html/snipeit/vendor/league/flysystem/src/AwsS3V3/VisibilityConverter.php", the first will be used.
Warning: Ambiguous class resolution, "League\Flysystem\AwsS3V3\PortableVisibilityConverter" was found in both "/var/www/html/snipeit/vendor/league/flysystem-aws-s3-v3/PortableVisibilityConverter.php" and "/var/www/html/snipeit/vendor/league/flysystem/src/AwsS3V3/PortableVisibilityConverter.php", the first will be used.
Warning: Ambiguous class resolution, "League\Flysystem\Local\FallbackMimeTypeDetector" was found in both "/var/www/html/snipeit/vendor/league/flysystem-local/FallbackMimeTypeDetector.php" and "/var/www/html/snipeit/vendor/league/flysystem/src/Local/FallbackMimeTypeDetector.php", the first will be used.
Warning: Ambiguous class resolution, "League\Flysystem\Local\LocalFilesystemAdapterTest" was found in both "/var/www/html/snipeit/vendor/league/flysystem-local/LocalFilesystemAdapterTest.php" and "/var/www/html/snipeit/vendor/league/flysystem/src/Local/LocalFilesystemAdapterTest.php", the first will be used.
Warning: Ambiguous class resolution, "League\Flysystem\Local\LocalFilesystemAdapter" was found in both "/var/www/html/snipeit/vendor/league/flysystem-local/LocalFilesystemAdapter.php" and "/var/www/html/snipeit/vendor/league/flysystem/src/Local/LocalFilesystemAdapter.php", the first will be used.
To resolve ambiguity in classes not under your control you can ignore them by path using exclude-files-from-classmap
> Illuminate\Foundation\ComposerScripts::postAutoloadDump
> @php artisan package:discover --ansi
> @php artisan vendor:publish --force --tag=livewire:assets --ansi
89 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
Warning: Ambiguous class resolution, "League\Flysystem\AwsS3V3\AwsS3V3AdapterTest" was found in both "/var/www/html/snipeit/vendor/league/flysystem-aws-s3-v3/AwsS3V3AdapterTest.php" and "/var/www/html/snipeit/vendor/league/flysystem/src/AwsS3V3/AwsS3V3AdapterTest.php", the first will be used.
Warning: Ambiguous class resolution, "League\Flysystem\AwsS3V3\S3ClientStub" was found in both "/var/www/html/snipeit/vendor/league/flysystem-aws-s3-v3/S3ClientStub.php" and "/var/www/html/snipeit/vendor/league/flysystem/src/AwsS3V3/S3ClientStub.php", the first will be used.
Warning: Ambiguous class resolution, "League\Flysystem\AwsS3V3\AwsS3V3Adapter" was found in both "/var/www/html/snipeit/vendor/league/flysystem-aws-s3-v3/AwsS3V3Adapter.php" and "/var/www/html/snipeit/vendor/league/flysystem/src/AwsS3V3/AwsS3V3Adapter.php", the first will be used.
Warning: Ambiguous class resolution, "League\Flysystem\AwsS3V3\VisibilityConverter" was found in both "/var/www/html/snipeit/vendor/league/flysystem-aws-s3-v3/VisibilityConverter.php" and "/var/www/html/snipeit/vendor/league/flysystem/src/AwsS3V3/VisibilityConverter.php", the first will be used.
Warning: Ambiguous class resolution, "League\Flysystem\AwsS3V3\PortableVisibilityConverter" was found in both "/var/www/html/snipeit/vendor/league/flysystem-aws-s3-v3/PortableVisibilityConverter.php" and "/var/www/html/snipeit/vendor/league/flysystem/src/AwsS3V3/PortableVisibilityConverter.php", the first will be used.
Warning: Ambiguous class resolution, "League\Flysystem\Local\FallbackMimeTypeDetector" was found in both "/var/www/html/snipeit/vendor/league/flysystem-local/FallbackMimeTypeDetector.php" and "/var/www/html/snipeit/vendor/league/flysystem/src/Local/FallbackMimeTypeDetector.php", the first will be used.
Warning: Ambiguous class resolution, "League\Flysystem\Local\LocalFilesystemAdapterTest" was found in both "/var/www/html/snipeit/vendor/league/flysystem-local/LocalFilesystemAdapterTest.php" and "/var/www/html/snipeit/vendor/league/flysystem/src/Local/LocalFilesystemAdapterTest.php", the first will be used.
Warning: Ambiguous class resolution, "League\Flysystem\Local\LocalFilesystemAdapter" was found in both "/var/www/html/snipeit/vendor/league/flysystem-local/LocalFilesystemAdapter.php" and "/var/www/html/snipeit/vendor/league/flysystem/src/Local/LocalFilesystemAdapter.php", the first will be used.
To resolve ambiguity in classes not under your control you can ignore them by path using exclude-files-from-classmap
> Illuminate\Foundation\ComposerScripts::postAutoloadDump
> @php artisan package:discover --ansi
> @php artisan vendor:publish --force --tag=livewire:assets --ansi
Generating optimized autoload files

 INFO Discovering packages.

  arietimmerman/laravel-scim-server ..................................... DONE
  eduardokum/laravel-mail-auto-embed .................................... DONE
  elibyy/tcpdf-laravel .................................................. DONE
  intervention/image .................................................... DONE
  laravel-notification-channels/google-chat ............................. DONE
  laravel-notification-channels/microsoft-teams ......................... DONE
  laravel/passport ...................................................... DONE
  laravel/slack-notification-channel .................................... DONE
  laravel/socialite ..................................................... DONE
  laravel/tinker ........................................................ DONE
  laravel/ui ............................................................ DONE
  laravelcollective/html ................................................ DONE
  livewire/livewire ..................................................... DONE
  nesbot/carbon ......................................................... DONE
  nunomaduro/collision .................................................. DONE
  nunomaduro/termwind ................................................... DONE
  osa-eg/laravel-teams-notification ..................................... DONE
  pragmarx/google2fa-laravel ............................................ DONE
  spatie/laravel-backup ................................................. DONE
  spatie/laravel-ignition ............................................... DONE
  spatie/laravel-signal-aware-command ................................... DONE
  tabuna/breadcrumbs .................................................... DONE
  unicodeveloper/laravel-password ....................................... DONE


   INFO  Publishing [livewire:assets] assets.

  Copying directory [vendor/livewire/livewire/dist] to [public/vendor/livewire]  DONE

Generated optimized autoload files containing 9930 classes


 INFO Discovering packages.

  arietimmerman/laravel-scim-server ..................................... DONE
  eduardokum/laravel-mail-auto-embed .................................... DONE
  elibyy/tcpdf-laravel .................................................. DONE
  intervention/image .................................................... DONE
  laravel-notification-channels/google-chat ............................. DONE
  laravel-notification-channels/microsoft-teams ......................... DONE
  laravel/passport ...................................................... DONE
  laravel/slack-notification-channel .................................... DONE
  laravel/socialite ..................................................... DONE
  laravel/tinker ........................................................ DONE
  laravel/ui ............................................................ DONE
  laravelcollective/html ................................................ DONE
  livewire/livewire ..................................................... DONE
  nesbot/carbon ......................................................... DONE
  nunomaduro/collision .................................................. DONE
  nunomaduro/termwind ................................................... DONE
  osa-eg/laravel-teams-notification ..................................... DONE
  pragmarx/google2fa-laravel ............................................ DONE
  spatie/laravel-backup ................................................. DONE
  spatie/laravel-ignition ............................................... DONE
  spatie/laravel-signal-aware-command ................................... DONE
  tabuna/breadcrumbs .................................................... DONE
  unicodeveloper/laravel-password ....................................... DONE


   INFO  Publishing [livewire:assets] assets.

  Copying directory [vendor/livewire/livewire/dist] to [public/vendor/livewire]  DONE

√ INFO  Configuration cache cleared successfully.
√ ERROR  Failed to clear cache. Make sure you have the appropriate permissions.
√ INFO  Route cache cleared successfully.
√ INFO  Compiled views cleared successfully.

--------------------------------------------------------
STEP 7: Putting application into maintenance mode:
--------------------------------------------------------

--
   INFO  Application is now in maintenance mode.

--------------------------------------------------------
STEP 8: Backing up database:
--------------------------------------------------------

-- Starting backup...
Dumping database snipeit...
Determining files to backup...
Zipping 1182 files and directories...
Created zip containing 1182 files and directories. Size is 70.04 MB
Copying zip to disk named backup...
Successfully copied zip to disk named backup.
Backup completed!

--------------------------------------------------------
STEP 9: Migrating database:
--------------------------------------------------------


   INFO  Nothing to migrate.


--------------------------------------------------------
STEP 10: Checking for OAuth keys:
--------------------------------------------------------

√ OAuth keys detected. Skipping passport install.

--------------------------------------------------------
STEP 11: Taking application out of maintenance mode:
--------------------------------------------------------

√ INFO  Application is now live.

---------------------- FINISHED! -----------------------
All done! Clear your browser cookies and re-login to use
your upgraded Snipe-IT!
--------------------------------------------------------

admin@SERVERNAME:/var/www/html/snipeit$

Did run these before upgrading:

$ git remote remove origin
$ git remote add origin https://github.com/grokability/snipe-it
$ git fetch --all 
$ git reset --hard origin/master

Thanks.

[swift2512]

@synergy34 it's due to permissions on your server. I have same 'issue' on my LAMP stack, but too lazy to fix it.
For me it's sudo chmod -R 775 /var/www/snipeit, for you it may be slightly different command.

[synergy34]

That resolved that Error, thanks.

Snipe-IT being stuck on v8.4.0 was handled separately. Git wasn't pulling from the correct location.

[synergy34]

Hey @snipe, before I do anything, is running sudo chmod -R 775 /var/www/snipeit going to break stuff (Or expose the .env)? Or is there a better way?

I have installed via the .sh script. So I believe the necessary chmod commands would have been run during setup...?

$ wget https://raw.githubusercontent.com/grokability/snipe-it/master/install.sh
$ chmod 744 install.sh
$ ./install.sh

Lines 543-546 in snipeit.sh:

 echo "* Clearing cache and setting final permissions."
        chmod 777 -R $APP_PATH/storage/framework/cache/
        log "run_as_app_user php $APP_PATH/artisan cache:clear"
        chmod 775 -R $APP_PATH/storage/

Possible Bug?

[snipe]

775 on the whole directory issn't a great idea. The only dirs that need to be writable are the storage directory and public/uploads.
https://snipe-it.readme.io/docs/debugging-permissions

[synergy34]

Oh Snaps! Already ran that... Now how to undo that change... This is where I should be looking at in the doc?