Possibly improved workflow for docker compose using profiles and make #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
looks good to me :) |
grokuku
added a commit
that referenced
this pull request
Jun 9, 2024
Merge pull request #47 from ilude/compose-profiles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is, what I would consider, an improved workflow. Please review and provide feedback and thoughts!
Basic gist of it is that all of the services are now defined in the docker-compose.yml and can be run independently, with one command. Or as a mix and match set of services without interfering with each other (each service now has its own host port).
All of this can be controlled/customized using variables that can be placed inside a .env file that is loaded by Make (which is not required and completely optional)
I also have another branch that takes this a step further and places the services behind a traefik proxy. This allows for services to be accessed using a url like the following:
https://sd-next.example.com
https://fooocus.example.com
That branch is here: https://github.com/ilude/stable-diffusion/tree/traefik-profiles
and I can submit a pull request for that if you would like.