Skip to content

Conversation

@aurel-g
Copy link
Contributor

@aurel-g aurel-g commented Aug 4, 2024

To ensure correct permissions, a recursive chown was made on /home/abc at each launch (in /docker/root/etc/s6-overlay/s6/rc.d/init-chown/run).
On some (file)systems, it could be quite long because there are many (small) files. (I'm note sure why, but in an lxc container on one of my servers it takes 2 minutes, whereas on another, more classic system, it is almost instantaneous).

I propose:

  1. a different way to change permissions on launch in case they are not correct, using find to detect dirs/files to change instead on chowning all the directory. It seems more efficient.

  2. furthermore, since the default values ​​of PGID and PUID environment variables are 1000 in docker-compose, and most users will not change them, I propose to modify the Ids of the user and group "abc" (which are 911 by default in the base image) directly when building the image, to limit the number of changes to be made after launching the container in the majority of use cases

  3. adding a chown on /home/abc after the installation of Miniconda

This fixes the performance issue I've been seeing, and I think it might help prevent future complications with file permissions.

@grokuku grokuku merged commit cbb9494 into grokuku:main Aug 7, 2024
@aurel-g aurel-g deleted the aurel-g-patch-1 branch August 7, 2024 20:25
@waguimxxxx
Copy link

Hello can i use this docker img on runpod.io?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants