Skip to content

PR grom72/trivy#16

Open
grom72 wants to merge 23 commits intomasterfrom
grom72/trivy
Open

PR grom72/trivy#16
grom72 wants to merge 23 commits intomasterfrom
grom72/trivy

Conversation

@grom72
Copy link
Copy Markdown
Owner

@grom72 grom72 commented Jul 31, 2024 •
edited
Loading

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

This change is Reviewable

grom72 added 23 commits June 25, 2024 16:53
@grom72
DAOS-623 ci: Add a workflow for Trivy scans
ce5510d 
Skip-test: true
Skip-unit-test: true
Skip-func-test: true

Required-githooks: true

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
@grom72
Minor changes after review
156e9a6 
Skip-test: true
Skip-unit-test: true
Skip-func-test: true

Required-githooks: true

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
@grom72
Limit the scope of workflow triggers
6c3d436 
Required-githooks: true

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
@grom72
Assume backport to release 2.6
c9da1db 
Required-githooks: true

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
@grom72
Revert "Assume backport to release 2.6"
c676df4 
This reverts commit 4ad656b.

Skip-test: true
Skip-unit-test: true
Skip-func-test: true

Required-githooks: true

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
@grom72
Revert "Revert "Assume backport to release 2.6""
cf121a2 
This reverts commit f5105c5.

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
@grom72
Solution that assumes backport to release 2.6 branch
b7277dd 
Skip-test: true
Skip-unit-test: true
Skip-func-test: true

Required-githooks: true

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
@grom72
Simplify file extension generation.
dd69b94 
Skip-test: true
Skip-unit-test: true
Skip-func-test: true

Required-githooks: true

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
@grom72
Merge remote-tracking branch 'origin/master' into grom72/trivy
a661156
@grom72
A new version based on GHA
e02ca0f 
Required-githooks: true

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
@grom72
Add sarif format scan
660b542 
Skip all functional tests
Doc-only: true

Required-githooks: true

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
@grom72
Fix typo
5489392 
Doc-only: true

Required-githooks: true

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
@grom72
Test for sarif w/ failures
666e3b9 
Doc-only: true
Required-githooks: true

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
@grom72
Backup Sarif file in the GitHub artifact store
bceb0ac 
Doc-only: true

Required-githooks: true

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
@grom72
Revert "Backup Sarif file in the GitHub artifact store"
0744af2 
Doc-only: true

This reverts commit bceb0ac.

Required-githooks: true

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
@grom72
Revert "Test for sarif w/ failures"
3036508 
This reverts commit 666e3b9.
Doc-only: true
Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
@grom72
Pin upload-sarif action by hash
857a1d4 
Required-githooks: true
Doc-only: true

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
@grom72
Revert "Revert "Test for sarif w/ failures""
0cc3fd3 
This reverts commit 3036508.
Doc-only: true

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
@grom72
Remove all ignores for test purpose
decae78 
Required-githooks: true

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
@grom72
Update hadoop to eliminate several CVE
a120cd1 
Required-githooks: true

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
@grom72
Revert "Remove all ignores for test purpose"
f132fb0 
This reverts commit decae78.
@grom72
remove unnecessary ignores
5a7a68c 
Required-githooks: true

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
@grom72
New ignore as of new hadoop
c2b4acc 
Required-githooks: true

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
grom72 pushed a commit that referenced this pull request Apr 8, 2026
@liw
DAOS-18673 pool: Initialize sp_recov_lock (daos-stack#17685)
2adb9b5 
Looks like ds_pool.sp_recov_lock is not initialized via
ABT_rwlock_create. This led to the following ABT error,

  #5  in ds_cont_tgt_open at src/container/srv_target.c:1954
  #6  in cont_iv_ent_update at src/container/container_iv.c:646
  #7  in update_iv_value at src/engine/server_iv.c:280
  #8  in iv_on_update_internal at src/engine/server_iv.c:490
  #9  in ivc_on_update at src/engine/server_iv.c:530
  #10 in crt_iv_update_internal at src/cart/crt_iv.c:3438
  #11 in crt_iv_update at src/cart/crt_iv.c:3559
  #12 in iv_op_internal at src/engine/server_iv.c:1080
  #13 in _iv_op at src/engine/server_iv.c:1129
  #14 in iv_op at src/engine/server_iv.c:1241
  #15 in ds_iv_update at src/engine/server_iv.c:1287
  #16 in cont_iv_update at src/container/container_iv.c:867
  #17 in cont_iv_capability_update at src/container/container_iv.c:1245
  #18 in cont_open at src/container/srv_container.c:2821
  #19 in cont_op_with_cont at src/container/srv_container.c:5613
  #20 in cont_op_with_svc at src/container/srv_container.c:5845
  #21 in ds_cont_op_handler at src/container/srv_container.c:6064
  #22 in ds_cont_op_handler_v8 at src/container/srv_container.c:6108
  #23 in crt_handle_rpc at src/cart/crt_rpc.c:1747

where the line was

  #5  in ds_cont_tgt_open at src/container/srv_target.c:1954
  1954            DABT_RWLOCK_RDLOCK(pool->sp_recov_lock);

Signed-off-by: Li Wei <liwei@hpe.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@grom72