Skip to content

add email input to feedback#4798

Closed
britt6612 wants to merge 3 commits intomasterfrom
add-email-feedback
Closed

add email input to feedback#4798
britt6612 wants to merge 3 commits intomasterfrom
add-email-feedback

Conversation

@britt6612
Copy link
Collaborator

Deploy Preview

What does this PR do?

add email option for our feedback on DS site

Where should the reviewer start?

layout.js

What testing has been done on this PR?

locally
In addition to the feature you are implementing, have you checked the following:

General UX Checks

  • Small, medium, and large screen sizes
  • Cross-browsers (FireFox, Chrome, and Safari)
  • Light & dark modes
  • All hyperlinks route properly

Accessibility Checks

  • Keyboard interactions
  • Screen reader experience
  • Run WAVE accessibility plugin (Chrome)

Code Quality Checks

  • Console is free of warnings and errors
  • Passes E2E commit checks
  • Visual snapshots are reasonable

How should this be manually tested?

locally

Any background context you want to provide?

be nice to have an option for users to give their contact (if they want) so we can follow up on any feedback that is left for us

What are the relevant issues?

just came up in Slack

Screenshots (if appropriate)

Should this PR be mentioned in Design System updates?

no

Is this change backwards compatible or is it a breaking change?

backwards compatible

@changeset-bot
Copy link

changeset-bot bot commented Feb 21, 2025

⚠️ No Changeset found

Latest commit: 41cd5b3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Feb 21, 2025

Deploy Preview for rad-shortbread-897892 failed.

Name Link
🔨 Latest commit 41cd5b3
🔍 Latest deploy log https://app.netlify.com/sites/rad-shortbread-897892/deploys/67e5fa541315ba0008ed43a9

@netlify
Copy link

netlify bot commented Feb 21, 2025

Deploy Preview for unrivaled-bublanina-3a9bae failed.

Name Link
🔨 Latest commit 41cd5b3
🔍 Latest deploy log https://app.netlify.com/sites/unrivaled-bublanina-3a9bae/deploys/67e5fa54591243000835cd67

@britt6612 britt6612 marked this pull request as draft February 21, 2025 19:48
@britt6612 britt6612 marked this pull request as ready for review February 21, 2025 20:14
@britt6612
Copy link
Collaborator Author

Turning to draft until I hear back from Doris for api but feel free to still look at wording

@britt6612 britt6612 marked this pull request as draft February 21, 2025 21:54
Co-authored-by: Matthew Glissmann <mdglissmann@gmail.com>
@britt6612
Copy link
Collaborator Author

closing in favor of #5251

@britt6612 britt6612 closed this Aug 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants