You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Updating t-shirt sizing docs to be less Grommet-focused and to remove the hard-coded values. Also, some of the core concepts are handled by some of the design tokens docs-- leveraging cross-linking to those pages.
Where should the reviewer start?
What testing has been done on this PR?
In addition to the feature you are implementing, have you checked the following:
General UX Checks
Small, medium, and large screen sizes
Cross-browsers (FireFox, Chrome, and Safari)
Light & dark modes
All hyperlinks route properly
Accessibility Checks
Keyboard interactions
Screen reader experience
Run WAVE accessibility plugin (Chrome)
Code Quality Checks
Console is free of warnings and errors
Passes E2E commit checks
Visual snapshots are reasonable
How should this be manually tested?
Any background context you want to provide?
What are the relevant issues?
Screenshots (if appropriate)
Should this PR be mentioned in Design System updates?
Is this change backwards compatible or is it a breaking change?
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
taysea
changed the title
Adjust tshirt sizing docs to be less Grommet-centric and cross-link t…
Adjust tshirt sizing docs to be less Grommet-centric
Feb 27, 2025
Sizes are intended to help give a UI a unified, harmonious experience. Therefore, there is a relationship between the pixel values that each size value maps to.
- A need to consult with your designer about why a custom value is needed.
- Something in the implementation can and should be simplified.
- There could be a gap in the Design System which should be reported and addressed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
taysea
changed the title
Deploy Preview
What does this PR do?
Updating t-shirt sizing docs to be less Grommet-focused and to remove the hard-coded values. Also, some of the core concepts are handled by some of the design tokens docs-- leveraging cross-linking to those pages.
Where should the reviewer start?
What testing has been done on this PR?
In addition to the feature you are implementing, have you checked the following:
General UX Checks
Accessibility Checks
Code Quality Checks
How should this be manually tested?
Any background context you want to provide?
What are the relevant issues?
Screenshots (if appropriate)
Should this PR be mentioned in Design System updates?
Is this change backwards compatible or is it a breaking change?