No longer need after latest rails commit

[dmitry]

More information is here: rails/rails@b477ad5

[grosser]

thanks!

will this be in 4.2 or 5.0 ?

[dmitry]

Looks like it will be only in 5.0 and not backported to 4.2, but anyway it's good to know that in future versions of rails there are no need to do any special rituals for marking the after_commit workable.

[grosser]

yep, added deprecation notice to readme

[dmitry]

Additional reference to PR: rails/rails#18458

[pepesenaris]

I just upgrade to rails 4.2 and none of my test are working. All are falling with the same line
TypeError: no implicit conversion of nil into String
test_after_commit (0.4.1) lib/test_after_commit.rb:15:in block in transaction_with_transactional_fixtures' test_after_commit (0.4.1) lib/test_after_commit.rb:9:intransaction_with_transactional_fixtures'

I pretty sure that it's the because of this issue.... What can do i do, other that using rails master?

[grosser]

idk works fine on my rails 4.2 app maybe because it's still on 0.2.2 :D
patch or failed test welcome!

[pepesenaris]

You mean version 0.2.2 of test_after_commit gem?
I'll try it right away

[grosser]

yep, did not update it by accident ... might work for whatever stupid
reason ...

On Mon, May 18, 2015 at 2:14 PM, pepesenaris notifications@github.com
wrote:

You mean version 0.2.2 of test_after_commit gem?
I'll try it right away

—
Reply to this email directly or view it on GitHub
#35 (comment)
.

[grosser]

Damn ... nope just updated it in another branch and works fine on 0.4.1 ...
so yeah no idea ...

On Mon, May 18, 2015 at 2:33 PM, Michael Grosser michael@grosser.it wrote:

yep, did not update it by accident ... might work for whatever stupid
reason ...

On Mon, May 18, 2015 at 2:14 PM, pepesenaris notifications@github.com
wrote:

You mean version 0.2.2 of test_after_commit gem?
I'll try it right away

—
Reply to this email directly or view it on GitHub
#35 (comment)
.

[pepesenaris]

well, no.... still does not work. it does not seems to be related to the test_after_commit version