Merged
Conversation
timmarkhuff
commented
Mar 18, 2026
| def hydrate_inference_config_names( | ||
| cls, value: dict[str, InferenceConfig | dict[str, Any]] | None | ||
| ) -> dict[str, InferenceConfig | dict[str, Any]]: | ||
| cls, value: Optional[dict[str, Union[InferenceConfig, dict[str, Any]]]] |
Contributor
Author
There was a problem hiding this comment.
This syntax is required for Python 3.9
Collaborator
There was a problem hiding this comment.
I made a ticket for us to drop 3.9 support in the future
timmarkhuff
commented
Mar 18, 2026
| if not filename.strip(): | ||
| raise ValueError("filename must be a non-empty path when provided.") | ||
| with open(filename, "r") as f: | ||
| with open(filename, "r", encoding="utf-8") as f: |
Contributor
Author
There was a problem hiding this comment.
The linter wants an explicit encoding set
timmarkhuff
commented
Mar 18, 2026
| ruff = "^0.4.4" | ||
| toml-sort = "^0.23.0" | ||
| types-PyYAML = "^6.0.0" | ||
| types-requests = "^2.28.11.17" |
Contributor
Author
There was a problem hiding this comment.
PyYAML doesn't ship type stubs, so mypy raises [import-untyped] on import yaml. This is the same pattern as types-requests above.
timmarkhuff
commented
Mar 18, 2026
|
|
||
|
|
||
| class GlobalConfig(BaseModel): | ||
| class GlobalConfig(BaseModel): # pylint: disable=too-few-public-methods |
Contributor
Author
There was a problem hiding this comment.
Pydantic data models intentionally have few methods. Pylint doesn't understand this pattern, so we suppress too-few-public-methods (same as RequestsRetryDecorator in internalapi.py)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#413 was merged in with a few linter errors. This PR fixes them.