fix(test): drop pipeline_config from invalid-priming-group test#429
Merged
brandon-wada merged 1 commit intomainfrom May 5, 2026
Merged
fix(test): drop pipeline_config from invalid-priming-group test#429brandon-wada merged 1 commit intomainfrom
brandon-wada merged 1 commit intomainfrom
Conversation
The backend now rejects pipeline_config + priming_group_id as mutually exclusive (zuuul PR #6286), so the call no longer reaches the PG-lookup step that this test is designed to exercise. Removing pipeline_config restores the original 404 path.
f-wright
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pipeline_config+priming_group_idtogether as mutually exclusivetest_create_detector_with_invalid_priming_group_idwas passing both, so it now fails with a 400 ("mutually exclusive") instead of reaching the PG-lookup step that returns the 404 the test asserts on.pipeline_configfrom the call. The test still does what its docstring says: passing a fake priming_group_id and expecting a 404 mentioningPrimingGroup.