fix(velocity): bake plugin-agones 0.7.2 so /agones counts the network - #195
Merged
Conversation
/agones reported one player in a lobby holding two. It read Velocity's playersConnected, which only ever counts the players on the proxy running the command — so with two proxies in front of one lobby each reported half of it, and the number looked entirely plausible. plugin-agones 0.7.2 asks the presence service instead, and says the figure is proxy-local when it cannot. The plugin is baked into this image rather than fetched at startup, so a fix in plugin-agones does nothing until the image is rebuilt and re-pinned.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/agonesreports one player in a lobby holding two.It read Velocity's
playersConnected, which only ever counts the players on theproxy running the command. With two proxies in front of one lobby each of them
reported half of it — and the number looked entirely plausible, which is why it
went unnoticed.
plugin-agones0.7.2 (groundsgg/plugin-agones#64) asks the presence serviceinstead, and explicitly says the figure is proxy-local when it cannot.
The plugin is baked into this image rather than fetched at startup, so the
fix in plugin-agones does nothing until this image is rebuilt and the deploy pin
moves to the new
sha-*tag.