chore(paper): drop plugin-agones-paper from default PLUGINS#92
Merged
chore(paper): drop plugin-agones-paper from default PLUGINS#92
Conversation
The paper baseImage is consumed exclusively by `type: plugin-paper` workloads (per BASE_IMAGE_TO_TYPE in grounds-forge/src/buildrunner/ manifest.ts). Forge renders those as plain Deployments — never as Agones-managed GameServers. The Agones SDK sidecar is only injected on GameServer-managed pods, so plugin-agones-paper in this image talks to a localhost:9358 that never exists. The plugin's own docs accept this state (`Errors are logged at severe level`) and groundsgg/plugin-agones#40 makes it inert when the env var is unset, but the simpler fix is to not bundle it here at all. If a future `type: gamemode` workload uses a Paper-based baseImage (rather than the current minestom-based one), plugin-agones-paper belongs in that image. Tracked separately. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
hbrombeer
added a commit
that referenced
this pull request
May 6, 2026
Surfaces #92 as a release-worthy change. The chore-prefixed merge removed plugin-agones-paper from PLUGINS= but didn't trigger release-please; this empty commit cuts a paper@v0.5.1 so the new image actually lands in GHCR for forge to pick up. User pods stop shipping the dead-weight plugin once forge bumps its baseImage tag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Paper baseImage is only used by
type: plugin-paperworkloads — those render as plain Deployments, never as Agones GameServers. The SDK sidecar never gets injected, so plugin-agones-paper here is permanently inert dead weight (and noise on boot until plugin-agones#40 ships). If a futuretype: gamemodePaper-based baseImage lands, the plugin belongs there.