Skip to content

feat: pass app flavor selection#51

Merged
lusu007 merged 1 commit into
mainfrom
feat/app-flavors
May 20, 2026
Merged

feat: pass app flavor selection#51
lusu007 merged 1 commit into
mainfrom
feat/app-flavors

Conversation

@lusu007
Copy link
Copy Markdown
Contributor

@lusu007 lusu007 commented May 20, 2026

Pull Request

Description

Adds grounds push --flavor=<key> and scopes local workspace override resolution to the selected manifest flavor. This keeps local bundle overrides aligned with the Paper, Velocity, or other flavor being pushed.

Type of Change

  • 🐛 Bug fix
  • ✨ New feature
  • 💥 Breaking change
  • ♻️ Refactoring
  • 📚 Documentation
  • 🔧 Chore

Related Issues

  • Fixes #

Testing

  • Unit tests pass
  • Manual testing completed
  • New tests added for new functionality

Ran:

  • /home/lukas/.local/bin/pkgx go test ./cmd/grounds/commands/push ./internal/workspace
  • /home/lukas/.local/bin/pkgx go test ./...
  • git diff --check

Checklist

  • I have performed a self-review of my own code
  • Tests have been added/updated and pass (if needed)
  • Documentation has been updated (if needed)

@lusu007 lusu007 marked this pull request as ready for review May 20, 2026 17:12
Copilot AI review requested due to automatic review settings May 20, 2026 17:12
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds support for selecting an app “flavor” during grounds push and uses that selection when resolving local workspace plugin overrides from grounds.yaml, so overrides align with the flavor being pushed (e.g., Paper vs Velocity).

Changes:

  • Add --flavor=<key> to grounds push and forward it to the Gradle groundsPush task.
  • Extend workspace resolution to read plugin lists from grounds.yaml flavors.<key>.plugins when flavors are present, requiring an explicit flavor selection in that case.
  • Add unit tests covering flavor-scoped workspace resolution and CLI forwarding of --flavor.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
internal/workspace/resolve.go Parse flavored manifests and scope plugin resolution to the selected flavor.
internal/workspace/resolve_test.go Add tests for flavored plugin selection and required-flavor behavior.
cmd/grounds/commands/push/push.go Introduce --flavor flag and forward it to Gradle + workspace resolution.
cmd/grounds/commands/push/push_test.go Add CLI test ensuring --flavor is forwarded to the Gradle wrapper.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread cmd/grounds/commands/push/push.go
Comment thread internal/workspace/resolve.go
Comment thread internal/workspace/resolve.go Outdated
@lusu007 lusu007 force-pushed the feat/app-flavors branch from 629ae46 to 0389546 Compare May 20, 2026 17:40
@lusu007 lusu007 merged commit 2138009 into main May 20, 2026
5 checks passed
@lusu007 lusu007 deleted the feat/app-flavors branch May 20, 2026 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants