feat: pass app flavor selection#51
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds support for selecting an app “flavor” during grounds push and uses that selection when resolving local workspace plugin overrides from grounds.yaml, so overrides align with the flavor being pushed (e.g., Paper vs Velocity).
Changes:
- Add
--flavor=<key>togrounds pushand forward it to the GradlegroundsPushtask. - Extend workspace resolution to read plugin lists from
grounds.yamlflavors.<key>.pluginswhen flavors are present, requiring an explicit flavor selection in that case. - Add unit tests covering flavor-scoped workspace resolution and CLI forwarding of
--flavor.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
internal/workspace/resolve.go |
Parse flavored manifests and scope plugin resolution to the selected flavor. |
internal/workspace/resolve_test.go |
Add tests for flavored plugin selection and required-flavor behavior. |
cmd/grounds/commands/push/push.go |
Introduce --flavor flag and forward it to Gradle + workspace resolution. |
cmd/grounds/commands/push/push_test.go |
Add CLI test ensuring --flavor is forwarded to the Gradle wrapper. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Adds
grounds push --flavor=<key>and scopes local workspace override resolution to the selected manifest flavor. This keeps local bundle overrides aligned with the Paper, Velocity, or other flavor being pushed.Type of Change
Related Issues
Testing
Ran:
/home/lukas/.local/bin/pkgx go test ./cmd/grounds/commands/push ./internal/workspace/home/lukas/.local/bin/pkgx go test ./...git diff --checkChecklist