fix: use deployment resource for platform commands#22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Fixes platform command polling for multi-flavor Minecraft workloads by separating the logical app name from the deployment resource name used by Forge's deployment-scoped service-account token.
The plugin now resolves the command deployment identity from
GROUNDS_RESOURCE_NAME, falls back to the Kubernetes Deployment name derived fromHOSTNAME, and finally falls back toGROUNDS_APP_NAMEfor older or local environments. Command lease and result callbacks use that deployment identity, while existing app-scoped behavior keeps the logical app name.Type of Change
Related Issues
Testing
Commands run:
./gradlew :common:test --tests 'gg.grounds.platform.PlatformEnvTest' --tests 'gg.grounds.platform.commands.PlatformCommandEnvTest' --tests 'gg.grounds.platform.commands.PlatformCommandClientTest'./gradlew test./gradlew spotlessApply./gradlew buildChecklist