Skip to content

fix: use deployment resource for platform commands#22

Merged
lusu007 merged 1 commit into
mainfrom
fix/platform-command-resource-name
Jun 5, 2026
Merged

fix: use deployment resource for platform commands#22
lusu007 merged 1 commit into
mainfrom
fix/platform-command-resource-name

Conversation

@lusu007
Copy link
Copy Markdown
Contributor

@lusu007 lusu007 commented Jun 5, 2026

Pull Request

Description

Fixes platform command polling for multi-flavor Minecraft workloads by separating the logical app name from the deployment resource name used by Forge's deployment-scoped service-account token.

The plugin now resolves the command deployment identity from GROUNDS_RESOURCE_NAME, falls back to the Kubernetes Deployment name derived from HOSTNAME, and finally falls back to GROUNDS_APP_NAME for older or local environments. Command lease and result callbacks use that deployment identity, while existing app-scoped behavior keeps the logical app name.

Type of Change

  • 🐛 Bug fix
  • ✨ New feature
  • 💥 Breaking change
  • ♻️ Refactoring
  • 📚 Documentation
  • 🔧 Chore

Related Issues

  • Fixes platform command execution for multi-flavor plugin-paper deployments

Testing

  • Unit tests pass
  • Manual testing completed
  • New tests added for new functionality

Commands run:

  • ./gradlew :common:test --tests 'gg.grounds.platform.PlatformEnvTest' --tests 'gg.grounds.platform.commands.PlatformCommandEnvTest' --tests 'gg.grounds.platform.commands.PlatformCommandClientTest'
  • ./gradlew test
  • ./gradlew spotlessApply
  • ./gradlew build

Checklist

  • I have performed a self-review of my own code
  • Tests have been added/updated and pass (if needed)
  • Documentation has been updated (if needed)

@lusu007 lusu007 marked this pull request as ready for review June 5, 2026 15:51
@lusu007 lusu007 merged commit bf029fb into main Jun 5, 2026
2 checks passed
@lusu007 lusu007 deleted the fix/platform-command-resource-name branch June 5, 2026 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant