feat(presence): report the proxy's region, and count players by proxy#27
Merged
Conversation
The session now carries where the proxy is, and the network can be counted per proxy rather than only per backend server. REGION is passed through exactly as the environment gives it, empty included. An absent region is a normal value all the way down — the column is nullable, the proto field tolerates empty, and inventing a plausible location for a proxy that never declared one would be worse than admitting we do not know. An empty region string becomes null at the API boundary so callers have a single shape for "unknown" rather than having to check for both.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last link. Needs
library-grpc-contracts-player0.5.0 andplugin-proxy-api0.3.0 — both released.REGIONwith the login, so the session records where the player iscountPlayersByProxy, which is what/onlinereadsregionontoPlayerSessionInfoREGIONis passed through exactly as the environment gives it, emptyincluded. An absent region is a normal value the whole way down — the column
is nullable, the proto tolerates empty — and inventing a plausible location for
a proxy that never declared one is worse than admitting we do not know.
At the API boundary an empty string becomes
null, so callers have one shapefor "unknown" instead of checking for both.
Build green including tests.