Conversation
Vic-Dev
force-pushed
the
BBD-261
branch
2 times, most recently
from
ba24ada to
c113381
Compare
effervescentia
suggested changes
Sep 30, 2016
Contributor
effervescentia
left a comment
effervescentia
left a comment
There was a problem hiding this comment.
otherwise, excellent
| } | ||
|
|
||
| restrictTotalRecords(total: number, pageSize: number): number { | ||
| const remainder = total % pageSize; |
Contributor
There was a problem hiding this comment.
probably don't need to calculate the remainder until line 91 as it's only used there. fine to keep it as a separate variable, but I feel like it should only be at the top if other things are going to use it
f f f f Bring back resetOffset Remove unneeded tests and fix tests f
effervescentia
approved these changes
Sep 30, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.