fix(BBD-724): When range refinement value is full bucket, don't apply any refinement#79
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #79 +/- ##
===========================================
+ Coverage 95% 95.08% +0.08%
===========================================
Files 3 3
Lines 220 224 +4
Branches 19 19
===========================================
+ Hits 209 213 +4
Misses 1 1
Partials 10 10
Continue to review full report at Codecov.
|
effervescentia
suggested changes
Sep 27, 2017
| displayName: string; | ||
| type: 'Value' | 'Range'; | ||
| range?: boolean; | ||
| rangeHighest?: number; |
Contributor
There was a problem hiding this comment.
I think a better name for these would be min and max
effervescentia
suggested changes
Sep 27, 2017
| const rangeHighest = 900; | ||
| const rangeLowest = 1; | ||
|
|
||
| let refinements = [ |
Contributor
There was a problem hiding this comment.
doesn't need to be a let because it is never re-assigned
effervescentia
approved these changes
Sep 28, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also need to see PR for flux-capacitor
groupby/flux-capacitor#76