feat: add TLS support #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thrawn01
approved these changes
Nov 3, 2024
Contributor
thrawn01
left a comment
thrawn01
left a comment
There was a problem hiding this comment.
Thank you for making this PR!
| return errors.New(strings.Join(errs, "\n")) | ||
| } | ||
| time.Sleep(time.Millisecond * 100) | ||
| wait(time.Millisecond * 100) |
Contributor
There was a problem hiding this comment.
Can you explain why time.Sleep isn't suitable here.
Contributor
Author
There was a problem hiding this comment.
@thrawn01 we can use sleep. This is just a preference.
Contributor
|
I added a test for TLS here #6. Your PR forced me to finally publish Thanks for providing me with the motivation! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically add the TLS support by adding a simple TLSConfig to the HttpTransportOptions.
@thrawn01 I hope this was your plan.