Fix/install ux#28
Merged
Merged
Conversation
.env.example sets OLLAMA_SSH_KEY_PUB to ~/.ssh/id_ed25519_ollama.pub but install.sh never created the file. Docker then auto-creates a directory at that path and fails mounting it as a file. Generate the key during install so the volume mount works on first boot. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
SSH peer communication was replaced by HTTP in Phase 2. The OLLAMA_SSH_KEY* mounts in docker-compose.yml were Phase 1 remnants — when the referenced files don't exist Docker fails to start the container. Remove the mounts and clean up the corresponding .env.example vars and install.sh key-generation block. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
docker-compose.yml mounts OLLAMA_SSH_KEY_PUB into the ollama container. If the .pub file is absent Docker auto-creates a directory there, then runc fails trying to bind-mount a file over a directory. Fix: generate the key pair during install, and remove any stale directory at the .pub path before writing the file. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ll injection eval "export $key=$val" interprets shell metacharacters in values — angle brackets, pipes, ampersands — as shell syntax. A literal placeholder like <cluster-llm-ip> caused bash to try a stdin redirect and exit 1, bringing the entire stack down. Use printf -v / export to set the variable safely. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
f765f22 removed the OLLAMA_SSH_KEY* volume mounts from docker-compose.yml (Phase 1 remnants, replaced by HTTP in Phase 2). A subsequent commit added key generation back to install.sh referencing those removed mounts. Dead code — the keys are no longer mounted anywhere. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type of change
Related issues
Testing
docker compose configpasses with no errorsshellcheckChecklist
.env.exampleis up to date (if env vars were added/removed)