Skip to content

Client serialization optimizations #1033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JamesNK merged 2 commits into from
Sep 2, 2020
Merged

Client serialization optimizations #1033

JamesNK merged 2 commits into from
Sep 2, 2020

Conversation

@JamesNK
Copy link
Member

@JamesNK JamesNK commented Aug 30, 2020 •
edited
Loading

Fixes #784

  • Reuse serialization contexts when streaming
  • Initialize write buffer initial capacity
  • Write directly to pooled array when length is known and there is no compression

@JamesNK JamesNK requested a review from JunTaoLuo August 30, 2020 02:26
JunTaoLuo
JunTaoLuo approved these changes Sep 2, 2020
View reviewed changes
@JamesNK JamesNK force-pushed the jamesnk/client-writer-optimization branch from cd8622b to c4310df Compare September 2, 2020 02:49
@JamesNK JamesNK force-pushed the jamesnk/client-writer-optimization branch from c4310df to 88bbd65 Compare September 2, 2020 03:22
@JamesNK JamesNK merged commit b10480c into grpc:master Sep 2, 2020
@JamesNK JamesNK deleted the jamesnk/client-writer-optimization branch September 2, 2020 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@JunTaoLuo JunTaoLuo JunTaoLuo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Optimize header allocation when using array writer

2 participants

@JamesNK @JunTaoLuo