Re-enable trim analysis and fix warnings #1744
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return null; | ||
| } | ||
|
|
||
| [SuppressMessage("Trimming", "IL2075", Justification = "Modern apps published with trimming will be using newer Grpc.Tools and won't use this fallback.")] |
Contributor
There was a problem hiding this comment.
Is this guaranteed and/or are the situations where it happens very edge-casey?
Member
Author
There was a problem hiding this comment.
Edge-casey. Apps won't use this path unless they use a Grpc.Tools version that's 2+ years old.
captainsafia
approved these changes
May 16, 2022
JamesNK
commented
May 16, 2022
| // Grpc.AspNetCore.Server uses reflection to find the bind service method. | ||
| // Grpc.AspNetCore.Server.Reflection uses reflection to find the descriptor property. | ||
| // DynamicallyAccessedMembersAttribute instructs the linker to never trim the members. | ||
| private const DynamicallyAccessedMemberTypes ServiceBinderAccessibility = DynamicallyAccessedMemberTypes.PublicMethods | DynamicallyAccessedMemberTypes.NonPublicMethods | DynamicallyAccessedMemberTypes.PublicProperties; |
Member
Author
There was a problem hiding this comment.
@jtattermusch FYI an update to Grpc.Core.Api. Just changes a value on an attribute. No impact on compatibility.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1667