Fix sending and receiving duplicate header names #918
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JunTaoLuo
approved these changes
May 21, 2020
Contributor
|
Awesome. I merged my changes to update to 2.29.0-pre1 earlier today - will re-run my tests tomorrow. Note: right now, I have both clients Vs the Google server, which has found a couple of deltas. Would it be useful for you if I try to update my test rig to do the full matrix of clients vs servers? Honestly, it was mostly done this way because it is easier to run the Google server in a fixture, but I could look at running Kestrel in a fixture. |
Member
Author
|
Sure, if it isn't too much time for you, and it is useful for you as well then go ahead. I'm not worried about being exactly identical with StatusCodes and detail messages, but differences around content and metadata are important to find. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #915
PR fixes concatenated values. I also noticed the server wasn't sending duplicate response headers.
I couldn't replicate having no headers. If might be fixed in 2.29.0-pre1.
@mgravell