Skip to content

Conversation

@gtcooke94
Copy link
Contributor

This adds support for configuring SPIFFE Bundle Maps inside of credentials via xds bundles.

See the gRFC for more detail grpc/proposal#462

RELEASE NOTES: N/A

@gtcooke94 gtcooke94 force-pushed the spiffe_xds_bundles_rebased branch from 1fdf43d to 77330a9 Compare March 17, 2025 19:07
@codecov
Copy link

codecov bot commented Mar 17, 2025

Codecov Report

Attention: Patch coverage is 86.36364% with 18 lines in your changes missing coverage. Please review.

Project coverage is 82.05%. Comparing base (1f6b0cf) to head (0bde4bb).
Report is 13 commits behind head on master.

Files with missing lines Patch % Lines
internal/testutils/tls_creds.go 55.00% 12 Missing and 6 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8177      +/-   ##
==========================================
- Coverage   82.42%   82.05%   -0.37%     
==========================================
  Files         393      410      +17     
  Lines       39162    40368    +1206     
==========================================
+ Hits        32280    33125     +845     
- Misses       5571     5872     +301     
- Partials     1311     1371      +60     
Files with missing lines Coverage Δ
credentials/tls/certprovider/pemfile/builder.go 100.00% <100.00%> (ø)
credentials/tls/certprovider/pemfile/watcher.go 86.56% <100.00%> (-2.99%) ⬇️
internal/credentials/spiffe/spiffe.go 100.00% <100.00%> (ø)
internal/xds/bootstrap/tlscreds/bundle.go 89.69% <100.00%> (+7.23%) ⬆️
internal/testutils/tls_creds.go 55.00% <55.00%> (ø)

... and 48 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gtcooke94 gtcooke94 force-pushed the spiffe_xds_bundles_rebased branch 4 times, most recently from 6b0c325 to 1b7b914 Compare March 17, 2025 19:54
@gtcooke94 gtcooke94 force-pushed the spiffe_xds_bundles_rebased branch from 928f54e to 0bde4bb Compare March 18, 2025 17:39
@arjan-bal
Copy link
Contributor

Is this a duplicate of #8180 that is being reviewed? Can this be closed?

@gtcooke94 gtcooke94 closed this Mar 31, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants