Upgrade deps; require Java 11 #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Error Prone 2.11 started requiring Java 11, so the previous version was
already the last version that supported Java 8. Error Prone 2.32
requires Java 17, so stopped on 2.31 for now.
This fixes:
```
java.lang.NoSuchMethodError: 'com.google.errorprone.matchers.Description$Builder com.google.errorprone.matchers.Description.builder(com.sun.source.tree.Tree, java.lang.String, java.lang.String, com.google.errorprone.BugPattern$SeverityLevel, java.lang.String)'
at io.grpc.annotations.checkers.ExperimentalApiChecker.describe(ExperimentalApiChecker.java:58)
```
Error Prone 2.18.0 marked Description.builder() as `@RestrictedApi`, and
then Error Prone 2.19.0 changed its signature.
Fixes grpc#29
jyane
reviewed
Nov 25, 2025
Member
jyane
left a comment
jyane
left a comment
There was a problem hiding this comment.
Thank you Eric for working on this.
kannanjgithub
approved these changes
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error Prone 2.11 started requiring Java 11, so the previous version was already the last version that supported Java 8. Error Prone 2.32 requires Java 17, so stopped on 2.31 for now.
This fixes:
Error Prone 2.18.0 marked Description.builder() as
@RestrictedApi, and then Error Prone 2.19.0 changed its signature.Fixes #29
@dsyer, fixing Java 11 without requiring Java 17 seems a good idea, as some people may still be using it for building (e.g., grpc-java itself, although it doesn't use this plugin). I also didn't mess with
<release>, as it brings in the--add-exportsgoo. I also migrated away from Description.Builder, since it is marked restricted.I may try to test this a bit more, but it seems pretty good. Specifically, the example needs changing, but I don't know if we'll do that after the release are before. Last release it seems we updated the example after the tag.
This is an alternative to #30