core: Improve language for leaked channel error#10746
Merged
ejona86 merged 1 commit intogrpc:masterfrom Dec 13, 2023
Merged
Conversation
Originally you had to confirm that awaitTermination() returned true, but that was annoying and useless, especially after calling shutdownNow(). The behavior was changed in ce2ae1f because the awaitTermination() detection logic could prevent the channel from getting garbage collected. Fixes grpc#10732
larry-safran
approved these changes
Dec 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally you had to confirm that awaitTermination() returned true, but that was annoying and useless, especially after calling shutdownNow(). The behavior was changed in ce2ae1f because the awaitTermination() detection logic could prevent the channel from getting garbage collected.
Fixes #10732
CC @Jasper-M