inprocess: Support tracing message sizes guarded by flag

[shivaspeaks]

Guarding #11406 by environment flag.

We are disabling retries within InProcess transport by default and only enabled while using this flag.

Context: #8712

[kannanjgithub]

You should do this in the specific test, not here which is the setup step for every test. We need to have 2 tests one that sets the property and one that doesn't. The test that does setProperty should have a try - finally block to System.clearProperty in the finally block as well.

[ejona86]

Since we would expect to have this flag for ~1 week and we want to get this in quickly (vs the larger revert), I suggest not testing at all with GRPC_EXPERIMENTAL_SUPPORT_TRACING_MESSAGE_SIZES=true (just use the default, whatever it is).

[shivaspeaks]

We shouldn't do this every message.

What does that mean? You mean we should move it to somewhere else? Perhaps to a place where constants are defined?

…

On Tue, 22 Oct 2024 at 8:19 PM, Eric Anderson ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In inprocess/src/main/java/io/grpc/inprocess/InProcessTransport.java <#11629 (comment)>: > @@ -358,6 +358,13 @@ private static int metadataSize(Metadata metadata) { return (int) size; } + /** + * Returns true if env var is set. + */ + static boolean isEnabledSupportTracingMessageSizes() { + return GrpcUtil.getFlag("GRPC_EXPERIMENTAL_SUPPORT_TRACING_MESSAGE_SIZES", false); We shouldn't do this every message. — Reply to this email directly, view it on GitHub <#11629 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ANRG3B6XM6IKQYRKNTFRBRTZ4ZQWXAVCNFSM6AAAAABQMLV5L6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGOBVGQ2TKOJXGA> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[ejona86]

You mean we should move it to somewhere else? Perhaps
to a place where constants are defined?

Add it as a field to the transport.