xds: Remember nonces for unknown types#11799
Merged
ejona86 merged 1 commit intogrpc:masterfrom Jan 6, 2025
Merged
Conversation
If the control plane sends a resource type the client doesn't understand at-the-moment, the control plane will still expect the client to include the nonce if the client subscribes to the type in the future. This most easily happens when unsubscribing the last resource of a type. Which meant 1cf1927 was insufficient.
larry-safran
approved these changes
Jan 6, 2025
danielzhaotongliu
approved these changes
Jan 6, 2025
Member
|
Good catch! FWIW, in C-core, since we never forget about a resource type once we've seen it, this wouldn't happen when unsubscribing to the last resource of a given type. It would happen only if the control plane spontaneously sent a resource type that the client never asked for, and I think that's sufficiently bad behavior on the part of the control plane that I'm not going to worry about it. |
Member
Author
|
@markdroth, yeah. And Go is also never removing resource types, so it would't be impacted either. |
ejona86
added
the
TODO:backport
This was referenced Jan 7, 2025
ejona86
removed
the
TODO:backport
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the control plane sends a resource type the client doesn't understand at-the-moment, the control plane will still expect the client to include the nonce if the client subscribes to the type in the future.
This most easily happens when unsubscribing the last resource of a type. Which meant 1cf1927 was insufficient.
CC @markdroth, @danielzhaotongliu