xds: Support filter state retention #11936
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiitk
force-pushed
the
xds-filter-state
branch
from
dd04593 to
39f9238
Compare
Introduces filter instance lifecycle. **xDS gRPC clients** New filter instances are created per combination of: 1. `XdsNameResolver` instance, 2. Filter name+typeUrl in HttpConnectionManager (HCM) http_filters. Existing client-side filter instances are shutdown: - A single a filter instance is shutdown when an LDS update contains HCM that is missing filter configuration for name+typeUrl combination of this instance. - All filter instances when watched LDS resource is missing from an LDS update. - All filter instances name resolver shutdown. **xDS-enabled gRPC servers** New filter instances are created per combination of: 1. Server instance, 2. FilterChain name, 3. Filter name+typeUrl in FilterChain's HCM.http_filters. Filter instances of Default Filter Chain is tracked separately per: 1. Server instance, 2. Filter name+typeUrl in default_filter_chain's HCM.http_filters. Existing server-side filter instances are shutdown: - A single a filter instance is shutdown when an LDS update contains FilterChain with HCM.http_filters that is missing configuration for filter name+typeUrl. - All filter instances associated with the FilterChain when an LDS update no longer contains FilterChain's name. - All filter instances when watched LDS resource is missing from an LDS update. - All filter instances on server shutdown.
sergiitk
force-pushed
the
xds-filter-state
branch
from
39f9238 to
ce2edde
Compare
Member
Author
ejona86
reviewed
Mar 5, 2025
Member
ejona86
left a comment
ejona86
left a comment
There was a problem hiding this comment.
Sending what I have. I need to still read XdsServerWrapper, but I'm not expecting any problems.
ejona86
approved these changes
Mar 5, 2025
Member
Author
|
/easycla Apparently "EasyCLA is broken at the moment; they are working on it" |
Member
Author
|
/easycla |
2 similar comments
Member
Author
|
/easycla |
Member
Author
|
/easycla |
Member
Author
|
For posterity, semi-related refactoring work and fixes: |
This was referenced May 24, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support filter state retention in Java. The mechanism will be similar to the one described in A83 for C-core, and will serve the same purpose. However, the implementation details are very different due to the different nature of xDS HTTP filter support in C-core and Java.
Filter instance lifecycle
xDS gRPC clients
New filter instances are created per combination of:
XdsNameResolverinstance,HttpConnectionManager(HCM) http_filters.Existing client-side filter instances are shutdown:
xDS-enabled gRPC servers
New filter instances are created per combination of:
FilterChainname,FilterChain's HCM.http_filters.Filter instances of Default Filter Chain is tracked separately per:
Existing server-side filter instances are shutdown:
FilterChainwith HCM.http_filters that is missing configuration for filter name+typeUrl.FilterChain-- when an LDS update no longer containsFilterChain's name.Related