Fix misleading exception in AdvancedTlsX509TrustManager when cert file is missing #12353
Conversation
| private long readAndUpdate(File trustCertFile, long oldTime) | ||
| throws IOException, GeneralSecurityException { | ||
| long newTime = checkNotNull(trustCertFile, "trustCertFile").lastModified(); | ||
| if (newTime == 0 && !trustCertFile.exists()) { |
There was a problem hiding this comment.
The check for !trustCertFile.exists() is redundant. See documentation for File.lastModified - 0 means file doesn't exist or an IO exception occurred. The exception we throw should say Certificate not found or not readable.
There was a problem hiding this comment.
@kannanjgithub Thanks for the feedback, I understand your point, to change this will removing the redundant trustCertFile.exists() check and throwing an appropriate IOException with message like "Certificate not found or not readable".
| @Test | ||
| public void missingFile_throwsFileNotFoundException() throws Exception { | ||
| AdvancedTlsX509TrustManager trustManager = AdvancedTlsX509TrustManager.newBuilder().build(); | ||
| Method readAndUpdateMethod = |
There was a problem hiding this comment.
You should not be calling the private method via reflection. Use the public method that calls it internally.
kannanjgithub
added
the
kokoro:run
grpc-kokoro
removed
the
kokoro:run
|
@Sangamesh1997, please follow our commit message convention (see "Follow typical Git commit message structure" bullet of CONTRIBUTING.md). The "fixes" should have been part of the commit message and really even the "java.security.GeneralSecurityException: Files were unmodified..." error should have been included. Otherwise it isn't clear what "misleading exception" you are talking about. |
…rt file is missing (grpc#12353)
…rt file is missing (grpc#12353)
4 participants
fixes : #10221
Adds a regression test using reflection on the private readAndUpdate() method to verify that a missing file properly results in a FileNotFoundException.