Skip to content

Conversation

@panchenko
Copy link
Contributor

@panchenko panchenko commented Oct 16, 2025

resolveAddresses() is a private method, called only once. There is no need to handle exceptions in multiple places.

The reason for creating this PR:
I have noticed an exception like this in the logs

2025-10-16 13:09:33.141 WARN  [grpc-default-executor-222]    ManagedChannelImpl            [Channel<47>: (x.y.com:443)] Failed to resolve name. status=Status{code=UNAVAILABLE, 
description=Unable to resolve host x.y.com, 
cause=java.lang.RuntimeException: java.net.UnknownHostException: x.y.com: nodename nor servname provided, or not known
...
Caused by: java.net.UnknownHostException: x.y.com: nodename nor servname provided, or not known
...
}

@panchenko panchenko marked this pull request as ready for review October 16, 2025 16:25
This reverts commit 6247935.
@kannanjgithub kannanjgithub added the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Oct 23, 2025
@grpc-kokoro grpc-kokoro removed the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Oct 23, 2025
@ejona86
Copy link
Member

ejona86 commented Oct 29, 2025

I keep re-running the Macos build, but it keeps stalling or getting an I/O failure...

@ejona86 ejona86 merged commit 4843256 into grpc:master Oct 30, 2025
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants