Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions api/src/main/java/io/grpc/NameResolver.java
Original file line number Diff line number Diff line change
Expand Up @@ -97,8 +97,14 @@ public void onError(Status error) {

@Override
public void onResult(ResolutionResult resolutionResult) {
listener.onAddresses(resolutionResult.getAddressesOrError().getValue(),
resolutionResult.getAttributes());
StatusOr<List<EquivalentAddressGroup>> addressesOrError =
resolutionResult.getAddressesOrError();
if (addressesOrError.hasValue()) {
listener.onAddresses(addressesOrError.getValue(),
resolutionResult.getAttributes());
} else {
listener.onError(addressesOrError.getStatus());
}
}
});
}
Expand Down
50 changes: 50 additions & 0 deletions api/src/test/java/io/grpc/NameResolverTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,56 @@ public void resolutionResult_hashCode() {
Objects.hashCode(StatusOr.fromValue(ADDRESSES), ATTRIBUTES, CONFIG));
}

@Test
public void startOnOldListener_resolverReportsError() {
final boolean[] onErrorCalled = new boolean[1];
final Status[] receivedError = new Status[1];

NameResolver resolver = new NameResolver() {
@Override
public String getServiceAuthority() {
return "example.com";
}

@Override
public void shutdown() {
}

@Override
public void start(Listener2 listener2) {
ResolutionResult errorResult = ResolutionResult.newBuilder()
.setAddressesOrError(StatusOr.fromStatus(
Status.UNAVAILABLE
.withDescription("DNS resolution failed with UNAVAILABLE")))
.build();

listener2.onResult(errorResult);
}
};

NameResolver.Listener listener = new NameResolver.Listener() {
@Override
public void onAddresses(
List<EquivalentAddressGroup> servers,
Attributes attributes) {
throw new AssertionError("Called onAddresses on error");
}

@Override
public void onError(Status error) {
onErrorCalled[0] = true;
receivedError[0] = error;
}
};

resolver.start(listener);

assertThat(onErrorCalled[0]).isTrue();
assertThat(receivedError[0].getCode()).isEqualTo(Status.Code.UNAVAILABLE);
assertThat(receivedError[0].getDescription()).isEqualTo(
"DNS resolution failed with UNAVAILABLE");
}

private static class FakeSocketAddress extends SocketAddress {
final String name;

Expand Down